TypeScript autocompletion unexpectedly prefers hyphens

[saschanaz]

• VSCode Version: 1.29.0
• OS Version: Windows 10

Steps to Reproduce:

Try autocompletion with hyphen-containing members. Here, "type" should appear first rather than second.

Does this issue occur when all extensions are disabled?: Yes

[mjbvz]

Simple repo:

const a = {
    x: 1,
    'x-y': 2
};

a.|

@jrieken Seems like a suggest sort issue. The entries that TS returns have the same sort text in this case

[jrieken]

Yeah, that's weird. A 100%-match should win over a prefix match...

[jrieken]

This is what happens:

• a.| and suggestion x: nothing will be replaced/overwritten, nothing to score against
• a.| and suggestion x-y: that suggestion has filter text .x-y and replaces . so we score . against .x-y which gives good score

Something similar happens with a.x and a._x_ vs a_.x_ (foo is the scoring range). Not sure what to do here, the rules are that longer scores are better but in this case it's not visible what being scored against...

[jrieken]

cc @chrisdias

[jrieken]

@mjbvz When having those bracket-member suggestions TypeScript could return a replace-range for all completions so that they all replace the leading dot and hence have the same ranking offset. Not sure what else to do there...

[jrieken]

👏 thanks @mjbvz