Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt createCachedData when possible #62643

Closed
jrieken opened this issue Nov 6, 2018 · 0 comments
Closed

Adopt createCachedData when possible #62643

jrieken opened this issue Nov 6, 2018 · 0 comments
Assignees
@jrieken
Labels
debt Code quality issues engineering VS Code - Build / issue tracking / etc. perf perf-startup upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Milestone
June 2019

Comments

@jrieken
Copy link
Member

jrieken commented Nov 6, 2018

Since Node.js 10.6 there is Script#createCachedData which allows to generate cached data whenever, esp not during first load. This will remove the pennelatly that we pay on the very first startup when we (1) don't have cached data and (2) tell the VM to generate it for us.
@jrieken jrieken self-assigned this Nov 6, 2018
@jrieken jrieken added upstream Issue identified as 'upstream' component related (exists outside of VS Code) debt Code quality issues perf engineering VS Code - Build / issue tracking / etc. perf-startup labels Nov 6, 2018
@rauchg rauchg mentioned this issue Nov 25, 2018
Closed
2 tasks
@jrieken jrieken mentioned this issue Jan 18, 2019
Merged
@bpasero bpasero added this to the May 2019 milestone May 1, 2019
@jrieken jrieken modified the milestones: May 2019, June 2019 May 24, 2019
jrieken added a commit to microsoft/vscode-loader that referenced this issue Jun 5, 2019
@jrieken
adopt offical createCachedData-api, emit cached data events as loader…
67a1e64 
… events, microsoft/vscode#62643
jrieken added a commit to microsoft/vscode-loader that referenced this issue Jun 6, 2019
@jrieken
avoid waterfall and load source and cached data in parallel, microsof…
58f437c 
…t/vscode#62643
@jrieken jrieken mentioned this issue Jun 6, 2019
Merged
jrieken added a commit that referenced this issue Jun 6, 2019
@jrieken
adopt new loader, add cached data stats to perf editor, #62643
dc8abec
@jrieken jrieken closed this as completed Jun 6, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
debt Code quality issues engineering VS Code - Build / issue tracking / etc. perf perf-startup upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Milestone
June 2019
Development

No branches or pull requests
2 participants
@bpasero @jrieken