Toggle word wrap Checkmark does not appear in Menubar

[miguelsolorio]

Issue Type: Bug

Even when I have my settings json file open I'm not seeing the change happen. If manually add the setting I can see the toggle working but the menu does not apply the checkmark.

VS Code version: Code - Insiders 1.29.0-insider (97ad72a, 2018-10-31T06:19:46.141Z)
OS version: Windows_NT x64 10.0.17134

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-7920HQ CPU @ 3.10GHz (4 x 3096)
GPU Status	2d_canvas: enabled checker_imaging: disabled_off flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: disabled_software rasterization: unavailable_software video_decode: enabled video_encode: enabled webgl: enabled webgl2: enabled
Memory (System)	3.98GB (1.30GB free)
Process Argv
Screen Reader	no
VM	67%

Extensions (3)

Extension	Author (truncated)	Version
vscode-pull-request-github	Git	0.2.2
vscode-typescript-tslint-plugin	ms-	0.0.2
ayu	tea	0.16.0

(2 theme extensions excluded)

[sbatten]

Word wrap is more complex than just the setting. The menubar action affects the transient state of word wrap, not the setting itself.

[jamesderlin]

This is incredibly confusing because the "Toggle Word Wrap" menu item is adjacent with "Toggle Minimap", "Toggle Render Whitespace", etc., all of which do use checkmarks.

I recommend either:
A. Rename "Toggle Word Wrap" to something else so that it's differentiated.
B. Make "Toggle Word Wrap" an actual toggle.

(I'd prefer B. Personally I find the word-wrap settings to be really confusing. My mental model is that
I expect two independent options: whether word wrap is enabled, and how word wrap should behave when enabled. VS Code merges both into a single setting, which means I can't do what I want, which is to leave word-wrap off by default but to wrap at my word wrap column when I explicitly toggle it.)

[david-waterworth]

Any plans to progress this? It's immensely frustrating to have to manually toggle word wrap on every time I open a file. I can see it not being a priority when working with source files as the general convention is to explicitly break long lines at say character 80. But I do a lot of documentation in latex where typically the convention is to let the editor wrap the text. So every time I open a file I have to toggle word wrap. The UI doesn't make sense since there's no way of visually telling the state, and there's no way of setting it on/off in the setting file (ideally it would also be able to be set by file type i.e. on for .tex and off for .py files)

[milesbuckton]

I'm looking forward to the release notes that reflect this as being fixed. 😄

[rebornix]

As discussed with @sbatten offline, one potential solution is adding a workbench contrib which can detects what's the word wrap state in the active editor and then set it to a global context key, and then the menu can read the state from the key. I'm assigning this back to @alexdima since I'm a bit lost with word wrap's transient state ;)

[miguelsolorio]

🥳 Verified this now works