Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should the '_workbench.downloadResource' command allow overwriting existing files? #59473

Closed
mjbvz opened this issue Sep 26, 2018 · 2 comments
Closed

Should the '_workbench.downloadResource' command allow overwriting existing files? #59473

mjbvz opened this issue Sep 26, 2018 · 2 comments
Assignees
@sandy081
Labels
info-needed Issue requires more information from poster

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Sep 26, 2018

Testing #59112

Repo
Execute the _workbench.downloadResource command twice with the same target folder on disk but different resources to download

Expected
Unclear what should happen here since we are trying to overwrite an existing file

Actual
The resource on disk is overwritten when the command in invoked the second time
@sandy081
Copy link
Member

Does the resources have the same name?

@sandy081 sandy081 added the info-needed Issue requires more information from poster label Sep 26, 2018
@vscodebot vscodebot bot closed this as completed Oct 3, 2018
@vscodebot
Copy link

vscodebot bot commented Oct 3, 2018

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
info-needed Issue requires more information from poster
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sandy081 @mjbvz