Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide an internal command to download resources #59112

Closed
sandy081 opened this issue Sep 21, 2018 · 4 comments
Closed

Provide an internal command to download resources #59112

sandy081 opened this issue Sep 21, 2018 · 4 comments
Assignees
@sandy081
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone
September 2018

Comments

@sandy081
Copy link
Member

Provide an internal command to download resources
@sandy081 sandy081 self-assigned this Sep 21, 2018
@sandy081 sandy081 added the feature-request Request for new features or functionality label Sep 21, 2018
@sandy081 sandy081 added this to the September 2018 milestone Sep 21, 2018
@sandy081 sandy081 mentioned this issue Sep 24, 2018
Closed
@sandy081
Copy link
Member Author

sandy081 commented Sep 24, 2018 •
edited
Loading

Verify that following command downloads the resource and the returns the location of the downloaded resource

vscode.commands.executeCommand('_workbench.downloadResource', vscode.Uri.parse('https://user-images.githubusercontent.com/1215681/35317099-5ccacae4-00d5-11e8-8cbc-b325f0358271.png') /* resource to download */).then(location => console.log(location.fsPath);

@sandy081 sandy081 added the verification-needed Verification of issue is requested label Sep 24, 2018
@mjbvz mjbvz added the verified Verification succeeded label Sep 26, 2018
@mjbvz mjbvz mentioned this issue Sep 26, 2018
Closed
@sandy081 sandy081 reopened this Sep 26, 2018
@sandy081 sandy081 added verification-found Issue verification failed and removed verified Verification succeeded labels Sep 26, 2018
sandy081 added a commit that referenced this issue Sep 27, 2018
@sandy081
#59112 Return the downloaded location
ea03e07
sandy081 added a commit that referenced this issue Sep 27, 2018
@sandy081
#59112 Return URI
1bcddf5
sandy081 added a commit that referenced this issue Sep 27, 2018
@sandy081
#59112 Return string
756a4e5
sandy081 added a commit that referenced this issue Sep 27, 2018
@sandy081
#59112 Return file URI
dd92ff0
@sandy081
Copy link
Member Author

@mjbvz Can you please verify it now.

@sandy081 sandy081 removed the verification-found Issue verification failed label Sep 27, 2018
@mjbvz mjbvz added the verified Verification succeeded label Sep 28, 2018
@sbatten
Copy link
Member

sbatten commented Sep 28, 2018

@sandy081 should we be killing the file extension?

@sandy081
Copy link
Member Author

sandy081 commented Oct 1, 2018

@sbatten Yes, We do not want to retain any extensions or names

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
September 2018
Development

No branches or pull requests
3 participants
@sbatten @sandy081 @mjbvz