Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow links in terminal that look like file(line,col) #58944

Closed
aliak00 opened this issue Sep 19, 2018 · 5 comments
Closed

Follow links in terminal that look like file(line,col) #58944

aliak00 opened this issue Sep 19, 2018 · 5 comments
Assignees
Labels
info-needed Issue requires more information from poster terminal General terminal issues that don't fall under another label

Comments

@aliak00
Copy link

aliak00 commented Sep 19, 2018

Follow links in terminal that look like file(line,col)

They are not linkified.

Sample output:

source/optional/optional.d(93,23): Error: cannot implicitly convert expression value of type int[] to immutable(int[])
tests/optional.d(424,11): Error: template instance `optional.optional.Optional!(int[]).Optional.__ctor!(int[], immutable(Optional!(int[])))` error instantiating
tests/optional.d(424,11): Error: none of the overloads of this are callable using argument types (int[]), candidates are:
source/optional/optional.d(97,5):        optional.optional.Optional!(immutable(int[])).Optional.this(const(None) _param_0)
source/optional/optional.d(92,5):  

Produced by compiling D source code with the dmd compiler.

Does this mean adding a regex entry here?: https://github.com/timbanaveen/vscode/blob/3984e251fd64c6e744d5d97d166e2437fb62e819/src/vs/workbench/parts/terminal/electron-browser/terminalLinkHandler.ts#L35

@vscodebot
Copy link

vscodebot bot commented Sep 19, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@vscodebot vscodebot bot added the terminal General terminal issues that don't fall under another label label Sep 19, 2018
@aliak00
Copy link
Author

aliak00 commented Sep 19, 2018

Sorry, forgot:
vscode version: 1.27.2
macOS High Sierra.

@Tyriar
Copy link
Member

Tyriar commented Sep 19, 2018

I can't seem to reproduce:

screen shot 2018-09-19 at 7 45 58 am

Note that this only works currently if the initial current working directory is the one that contains source/ and tests/ as we don't track the cwd changes yet.

@Tyriar Tyriar added the info-needed Issue requires more information from poster label Sep 19, 2018
@aliak00
Copy link
Author

aliak00 commented Sep 19, 2018 via email

@Tyriar
Copy link
Member

Tyriar commented Sep 19, 2018

@aliak00 good news 🙂, here's the feature request for tracking the cwd for links #27107

@Tyriar Tyriar closed this as completed Sep 19, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster terminal General terminal issues that don't fall under another label
Projects
None yet
Development

No branches or pull requests

2 participants