Editor layout is called on every config change

[roblourens]

I noticed that 'layout' is called on every config change, not just ones that actually change the size of the editor. 'layout' triggers a refresh in the settings editor. I can work around it in the settings editor but avoiding this would be a nice optimization. Seems to be menu related

SettingsEditor2.layout (/Users/roblou/code/vscode/src/vs/workbench/parts/preferences/browser/settingsEditor2.ts:149)
EditorControl.layout (/Users/roblou/code/vscode/src/vs/workbench/browser/parts/editor/editorControl.ts:232)
EditorGroupView.layout (/Users/roblou/code/vscode/src/vs/workbench/browser/parts/editor/editorGroupView.ts:1350)
LeafNode.orthogonalLayout (/Users/roblou/code/vscode/src/vs/base/browser/ui/grid/gridview.ts:444)
BranchNode.layout (/Users/roblou/code/vscode/src/vs/base/browser/ui/grid/gridview.ts:170)
GridView.layout (/Users/roblou/code/vscode/src/vs/base/browser/ui/grid/gridview.ts:547)
Grid.layout (/Users/roblou/code/vscode/src/vs/base/browser/ui/grid/grid.ts:218)
SerializableGrid.layout (/Users/roblou/code/vscode/src/vs/base/browser/ui/grid/grid.ts:495)
GridWidgetView.layout (/Users/roblou/code/vscode/src/vs/workbench/browser/parts/editor/editorPart.ts:76)
CenteredViewLayout.layout (/Users/roblou/code/vscode/src/vs/base/browser/ui/centered/centeredViewLayout.ts:81)
EditorPart.doLayout (/Users/roblou/code/vscode/src/vs/workbench/browser/parts/editor/editorPart.ts:906)
EditorPart.layout (/Users/roblou/code/vscode/src/vs/workbench/browser/parts/editor/editorPart.ts:897)
WorkbenchLayout.layout (/Users/roblou/code/vscode/src/vs/workbench/browser/layout.ts:651)
Workbench.setMenubarVisibility (/Users/roblou/code/vscode/src/vs/workbench/electron-browser/workbench.ts:1441)
Workbench.onDidUpdateConfiguration (/Users/roblou/code/vscode/src/vs/workbench/electron-browser/workbench.ts:594)
(anonymous function) (/Users/roblou/code/vscode/src/vs/workbench/electron-browser/workbench.ts:504)
Emitter.fire (/Users/roblou/code/vscode/src/vs/base/common/event.ts:140)
WorkspaceService.triggerConfigurationChange (/Users/roblou/code/vscode/src/vs/workbench/services/configuration/node/configurationService.ts:679)
WorkspaceService.onUserConfigurationChanged (/Users/roblou/code/vscode/src/vs/workbench/services/configuration/node/configurationService.ts:548)
(anonymous function) (/Users/roblou/code/vscode/src/vs/workbench/services/configuration/node/configurationService.ts:82)
Emitter.fire (/Users/roblou/code/vscode/src/vs/base/common/event.ts:140)
(anonymous function) (/Users/roblou/code/vscode/src/vs/platform/configuration/node/configuration.ts:33)
Emitter.fire (/Users/roblou/code/vscode/src/vs/base/common/event.ts:140)
(anonymous function) (/Users/roblou/code/vscode/src/vs/base/node/config.ts:197)
(anonymous function) (/Users/roblou/code/vscode/src/vs/base/node/config.ts:109)
(anonymous function) (/Users/roblou/code/vscode/node_modules/graceful-fs/graceful-fs.js:78)
readFileAfterClose (original-fs.js:511)

[bpasero]

@sbatten looks like a simple check if something has changed is needed here:

https://github.com/Microsoft/vscode/blob/8e6c09cdaea91bc9a415c8eafa78f97c33d61c10/src/vs/workbench/electron-browser/workbench.ts#L1438

I would vote to add this to the recovery release.