Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCM: Allow SourceControl implementations to hide the SourceControlInputBox #51808

Closed
lostintangent opened this issue Jun 14, 2018 · 0 comments
Closed

SCM: Allow SourceControl implementations to hide the SourceControlInputBox #51808

lostintangent opened this issue Jun 14, 2018 · 0 comments
Assignees
@joaomoreno
Labels
feature-request Request for new features or functionality on-testplan scm General SCM compound issues
Milestone
October 2018

Comments

@lostintangent
Copy link
Member

lostintangent commented Jun 14, 2018 •
edited
Loading

Currently, the SourceControl API doesn't appear to allow implementations to hide the commit input box. For Live Share, this would be valuable, since on the "guest" side, we'd like to provide read-only access of the host's local changes, but not allow any source control operations to be performed. The API already allows controlling which actions are exposed (which is perfect!), but to round out this experience, it would be great to hide the commit box as well.

If the SourceControlInputBox interface had a property called visible (or something equivalent), that allowed implementations to hide it, that would be great. Thanks!

// CC @jasongin
@jrieken jrieken assigned joaomoreno and unassigned jrieken Jun 14, 2018
@joaomoreno joaomoreno added feature-request Request for new features or functionality scm General SCM compound issues labels Jun 14, 2018
@joaomoreno joaomoreno added this to the Backlog milestone Jun 14, 2018
@joaomoreno joaomoreno removed their assignment Jun 14, 2018
@joaomoreno joaomoreno added the help wanted Issues identified as good community contribution opportunities label Sep 14, 2018
@joaomoreno joaomoreno changed the title [SCM] Allow SourceControl implementations to hide the SourceControlInputBox SCM: Allow SourceControl implementations to hide the SourceControlInputBox Sep 14, 2018
IlyaBiryukov pushed a commit to IlyaBiryukov/vscode that referenced this issue Oct 5, 2018
Allow scc providers hide commit input box.
212aade 
Fix for microsoft#51808.
@IlyaBiryukov IlyaBiryukov mentioned this issue Oct 5, 2018
Merged
@kieferrm kieferrm mentioned this issue Oct 7, 2018
Closed
38 tasks
@joaomoreno joaomoreno modified the milestones: Backlog, October 2018 Oct 8, 2018
@joaomoreno joaomoreno self-assigned this Oct 8, 2018
@joaomoreno joaomoreno removed the help wanted Issues identified as good community contribution opportunities label Oct 8, 2018
@joaomoreno joaomoreno mentioned this issue Oct 29, 2018
Closed
2 tasks
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
feature-request Request for new features or functionality on-testplan scm General SCM compound issues
Projects
None yet
Milestone
October 2018
Development

No branches or pull requests
3 participants
@joaomoreno @lostintangent @jrieken