Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for custom SymbolKind values #50186

Closed
fabiospampinato opened this issue May 20, 2018 · 4 comments
Closed

Support for custom SymbolKind values #50186

fabiospampinato opened this issue May 20, 2018 · 4 comments
Assignees
Labels
*out-of-scope Posted issue is not in scope of VS Code outline Source outline view issues under-discussion Issue is under discussion for relevance, priority, approach

Comments

@fabiospampinato
Copy link
Contributor

fabiospampinato commented May 20, 2018

I've added Go to Symbols support to Todo+, and I had to pick a SymbolKind, but none of them makes sense for this extension, as it's not providing syntax highlighting for a programming language.

I think there should either be support for passing no value for SymbolKind (hiding the icon, this is not happening at the moment) or support for defining custom SymbKinds.

screen shot 2018-05-20 at 17 05 10

@jrieken jrieken added under-discussion Issue is under discussion for relevance, priority, approach outline Source outline view issues labels May 29, 2018
@jrieken
Copy link
Member

jrieken commented May 29, 2018

support for passing no value for SymbolKind (hiding the icon, this is not happening at the moment) or support for defining custom SymbKinds.

We will not so custom icons because that puts a higher burden onto extension authors, esp when this bubbles up to the LSP which then means you can to provide icons matching various different IDEs/editors. Having no icon seems like an option but might also look weird when having mixed items, e.g. with and without icon...

@fabiospampinato
Copy link
Contributor Author

We will not so custom icons because that puts a higher burden onto extension authors

How so? They could just keep using one of the available SymbolKinds.

Having no icon seems like an option but might also look weird when having mixed items, e.g. with and without icon...

In my particular case I'm only providing file-level symbols, and there aren't any other symbols providers for that file type.

IMO it would also be weird if 2 completely different things use the same symbol, i.e. maybe somebody uses SymbolKind.Field for fields while my extension uses it for projects, mostly just because that icon has the same color as projects in *.todo files highlighted by my extension.

@jrieken jrieken added the *out-of-scope Posted issue is not in scope of VS Code label Sep 11, 2018
@vscodebot
Copy link

vscodebot bot commented Sep 11, 2018

This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!

@Q-back
Copy link

Q-back commented Aug 31, 2022

@jrieken
I'm confused. Do you mean that it will not be possible to provide custom icons for outline/symbol list? #51334
On the other hand here you said it should be possible.

Can you confirm if it's possible to provide custom icons for outline, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
*out-of-scope Posted issue is not in scope of VS Code outline Source outline view issues under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

3 participants