Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Voice Over: "Read character" command not working in integrated terminal #42559

Closed
mjbvz opened this issue Jan 30, 2018 · 3 comments · Fixed by #77887
Closed

Voice Over: "Read character" command not working in integrated terminal #42559

mjbvz opened this issue Jan 30, 2018 · 3 comments · Fixed by #77887
Assignees
@Tyriar
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone
July 2019

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Jan 30, 2018 •
edited
Loading

#42278

  • VSCode Version: Version 1.20.0-insider (1.20.0-insider)
  • OS Version: MacOS 10.13

Steps to Reproduce:

  1. Enable voice over
  2. In terminal
  3. Focus on prompt
  4. Trigger the Read Character command : VO+c (ctrl+option+c)

expected
Reads character at cursor

Actual
Does not. Says "End of Text"

Seems to work in MacOS terminal

Does this issue occur when all extensions are disabled?: Yes
@mjbvz mjbvz added the accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues label Jan 30, 2018
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues labels Feb 21, 2018
@Tyriar
Copy link
Member

Tyriar commented Feb 21, 2018

This happens because the backing textarea and the cursor is not synced with the actual prompt as it's a very tricky problem. This would need a fairly robust solution to #20676

@cleidigh cleidigh added accessibility-voiceover and removed accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels Oct 12, 2018
@isidorn isidorn added the accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues label Jun 19, 2019
@Tyriar Tyriar added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Jul 22, 2019
@Tyriar Tyriar added this to the July 2019 milestone Jul 22, 2019
@Tyriar
Copy link
Member

Tyriar commented Jul 22, 2019

xtermjs/xterm.js#2329

Tyriar added a commit that referenced this issue Jul 24, 2019
@Tyriar
[email protected]
f20eb76 
Diff: xtermjs/xterm.js@e99de7a...52c562d

Changes:

- Fix edge cases in inputhandler methods
- A lot of layering changes
- Dependency security updates
- test script for mouse modes
- Improve logging system
- Announce input and backspace on VoiceOver
- Fix test exit code

Fixes #42559
Fixes #56468
@Tyriar Tyriar mentioned this issue Jul 24, 2019
Merged
@rebornix rebornix added the verification-found Issue verification failed label Aug 1, 2019
@rebornix
Copy link
Member

rebornix commented Aug 1, 2019

I tried on macOS but still hear "End of text" all the time.

@rebornix rebornix reopened this Aug 1, 2019
@rebornix rebornix added verified Verification succeeded and removed verification-found Issue verification failed labels Aug 1, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Milestone
July 2019
Development

Successfully merging a pull request may close this issue.

[email protected] microsoft/vscode
6 participants
@roblourens @rebornix @isidorn @Tyriar @mjbvz @cleidigh