Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Git clone prompt should handle ~ #39738

Closed
roblourens opened this issue Dec 5, 2017 · 5 comments · Fixed by #39960
Closed

Git clone prompt should handle ~ #39738

roblourens opened this issue Dec 5, 2017 · 5 comments · Fixed by #39960
Assignees
@joaomoreno
Labels
feature-request Request for new features or functionality git GIT issues good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities verification-needed Verification of issue is requested verified Verification succeeded
Milestone
January 2018

Comments

@roblourens
Copy link
Member

Given #31878, I should be able to

  • Run Git: Clone
  • In parent directory prompt, enter ~/foo
  • Get popup Git: EACCES: permission denied, mkdir '~'
@roblourens roblourens added feature-request Request for new features or functionality git GIT issues labels Dec 5, 2017
@joaomoreno joaomoreno added this to the Backlog milestone Dec 6, 2017
@joaomoreno joaomoreno added good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities labels Dec 6, 2017
@joaomoreno joaomoreno removed their assignment Dec 6, 2017
@ampzord
Copy link

ampzord commented Dec 6, 2017

@joaomoreno Hasn't this issue been solved before ? #32222
If it hasn't I'll try to fix it.

@joaomoreno
Copy link
Member

@ampzord Actually it seems the current solution can only handle ~ in the config setting... but not in the input box!

@pfongkye
Copy link
Contributor

pfongkye commented Dec 7, 2017

@joaomoreno hello
I could take a look at the issue if no one is already assigned. It would be my first one.
Regards,
Pascal.

@pfongkye
Copy link
Contributor

pfongkye commented Dec 8, 2017

Hi @ampzord, let me know if you're working on the issue. I think I've found a solution.

pfongkye pushed a commit to pfongkye/vscode that referenced this issue Dec 8, 2017
fix: microsoft#39738
641e287 
Replaces starting tilde with home directory when entered in git clone prompt
@ampzord
Copy link

ampzord commented Dec 9, 2017

go for it @pfongkye !

@pfongkye pfongkye mentioned this issue Dec 9, 2017
Merged
@joaomoreno joaomoreno modified the milestones: Backlog, December 2017/January 2018 Dec 15, 2017
@joaomoreno joaomoreno added the verification-needed Verification of issue is requested label Dec 15, 2017
@joaomoreno joaomoreno self-assigned this Dec 15, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 29, 2018
@ramya-rao-a ramya-rao-a added the verified Verification succeeded label Feb 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
feature-request Request for new features or functionality git GIT issues good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
January 2018
Development

Successfully merging a pull request may close this issue.

fix: #39738 pfongkye/vscode
5 participants
@joaomoreno @roblourens @pfongkye @ampzord @ramya-rao-a