Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty sidebar. Files are not listed. #37693

Closed
Sarav-S opened this issue Nov 6, 2017 · 17 comments
Closed

Empty sidebar. Files are not listed. #37693

Sarav-S opened this issue Nov 6, 2017 · 17 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release file-explorer Explorer widget issues
Milestone

Comments

@Sarav-S
Copy link

Sarav-S commented Nov 6, 2017

  • VSCode Version: Code 1.15.1 (41abd21, 2017-08-16T17:15:57.756Z)
  • OS Version: Darwin x64 16.7.0
  • Extensions:
Extension Author (truncated) Version
crane Hvy 0.3.8
blockalign San 0.6.0
php-formatter Sop 0.2.4
php-debug fel 1.11.1
php-intellisense fel 1.5.1
phpcs ika 0.7.0
sublime-keybindings ms- 3.0.2
php-docblocker nei 1.3.0
laravel-blade one 1.10.0

Steps to Reproduce:

  1. File open folder -> chose my project folder
  2. I got empty sidebar with no files listed. Even ctrl + R/Recent project folder too didn't work.

Reproduces without extensions: Yes/No

@vscodebot vscodebot bot added the php PHP support issues label Nov 6, 2017
@roblourens roblourens removed the php PHP support issues label Nov 6, 2017
@roblourens roblourens removed their assignment Nov 6, 2017
@roblourens
Copy link
Member

Does this happen with every folder or just a particular one?

@roblourens roblourens added the info-needed Issue requires more information from poster label Nov 6, 2017
@Sarav-S
Copy link
Author

Sarav-S commented Nov 6, 2017

It happens with every folder. Trying to open projects with File->Open Recents or Ctrl+R also dint work out.

@bpasero
Copy link
Member

bpasero commented Nov 6, 2017

@Sarav-S can you make sure to update to our lated 1.17 release.

@Sarav-S
Copy link
Author

Sarav-S commented Nov 6, 2017

screen shot 2017-11-06 at 12 11 42 pm

I think I have the latest version @bpasero

@bpasero
Copy link
Member

bpasero commented Nov 6, 2017

@Sarav-S can you share a screenshot how your files explorer in the sidebar looks like?

@Sarav-S
Copy link
Author

Sarav-S commented Nov 6, 2017

screen shot 2017-11-06 at 12 21 12 pm

After adding folder through File->Open or File->Open Recents or Ctrl+R, I get only welcome screen.

@Sarav-S
Copy link
Author

Sarav-S commented Nov 6, 2017

You can see my project title VSCode header. Actually the files are available when I do Cmd+P to open them. But it isn't available only on sidebar

@bpasero
Copy link
Member

bpasero commented Nov 6, 2017

@sandy081 didn't we push a change so that the files explorer is never hidden?

@Sarav-S if you right click on the title of the explorer you should be able to bring back the files explorer properly.

@bpasero bpasero added the file-explorer Explorer widget issues label Nov 6, 2017
@Sarav-S
Copy link
Author

Sarav-S commented Nov 6, 2017

@bpasero I think explorer is open only except files are not listed. Please check screenshot.

screen shot 2017-11-06 at 12 32 31 pm

@Sarav-S
Copy link
Author

Sarav-S commented Nov 6, 2017

@bpasero I have this same issue, except for Mac OS Sierra https://screencast-o-matic.com/watch/cbnt3w634b

@bpasero
Copy link
Member

bpasero commented Nov 6, 2017

@Sarav-S do you see this context menu:

image

@Sarav-S
Copy link
Author

Sarav-S commented Nov 6, 2017

screen shot 2017-11-06 at 2 48 53 pm

You mean this one?

@sandy081
Copy link
Member

sandy081 commented Nov 6, 2017

Looks like we broke this in 1.17 while refactoring split view and views viewlet. And it is pretty bad.

Till 1.15 we were supporting toggling files explorer visibility. In 1.16 we took off that support #32962 here also making sure previous state is not considered. After refactoring we are no longer overriding the previous state.

I think this should be a candidate for 1.18 release.

@sandy081 sandy081 added this to the October 2017 milestone Nov 6, 2017
@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release and removed info-needed Issue requires more information from poster labels Nov 6, 2017
@sandy081
Copy link
Member

sandy081 commented Nov 6, 2017

Steps to reproduce:

  • Download 1.15 version of VS Code
  • Open VS Code on a folder
  • Hide the file explorer view
  • Update to latest

Expected: File explorer is not shown and cannot be retrieved

Analysis:
Looks like we broke this in 1.17 while refactoring split view and views viewlet.
Till 1.15 we were supporting toggling files explorer visibility. In 1.16 we took off that support #32962 here also making sure previous state is not considered. After refactoring we are no longer overriding the previous state.

Impact: Low
Users who had file explorer hidden in 1.15 release might not see file explorer and also cannot retrieve it after upgrading to latest version. Workaround is to upgrade to insiders containing the fix or clear cache for that folder as follows:

  • Close the window opening the folder that has this issue
  • Open new empty Window
  • Run command Developer: Toggle Developer Tools
  • Go to Application Tab in Developer tools
  • Select file:// under Local Storage section in the menu on the left
  • Search for the key workbench.explorer.views.state using Filter inputbox
  • Select the folder with this key and Delete it
  • Now open the folder in VS Code and you should be seeing the file explorer.

kapture 2017-11-06 at 12 54 24

Also, I only see 2 users filed this issue till now.

@sandy081 sandy081 reopened this Nov 6, 2017
@Sarav-S
Copy link
Author

Sarav-S commented Nov 6, 2017

@sandy081 Thanks! It worked :)

@Sarav-S Sarav-S closed this as completed Nov 6, 2017
@sandy081
Copy link
Member

sandy081 commented Nov 6, 2017

Reopening it for discussion for including it in October release or not.

@sandy081 sandy081 reopened this Nov 6, 2017
@roblourens
Copy link
Member

It is quite bad, and the fix looks simple, I think we should get it in for October.

sandy081 added a commit that referenced this issue Nov 7, 2017
@sandy081 sandy081 closed this as completed Nov 7, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release file-explorer Explorer widget issues
Projects
None yet
Development

No branches or pull requests

4 participants