Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use strict version-identifier for @types/xyz-modules #35561

Closed
jrieken opened this issue Oct 4, 2017 · 5 comments
Closed

Use strict version-identifier for @types/xyz-modules #35561

jrieken opened this issue Oct 4, 2017 · 5 comments
Assignees
@mjbvz
Labels
debt Code quality issues important Issue identified as high-priority
Milestone
October 2017

Comments

@jrieken
Copy link
Member

jrieken commented Oct 4, 2017 •
edited
Loading

This is a source of breakage. For instance, we needed to push 81fc22e to the release/1.17-branch because some d.ts files had changed so that we cannot compile anymore. For the a similar reason we are not able to compile from our release/1.15 branch anymore. This is scary and while the underlying issue is d-ts-modules not caring about semver-semantics we should be acknowledging that and be strict when adding @types/foo dependencies.
@vscodebot vscodebot bot assigned mjbvz Oct 4, 2017
@vscodebot vscodebot bot added the typescript Typescript support issues label Oct 4, 2017
@jrieken jrieken removed the typescript Typescript support issues label Oct 4, 2017
@jrieken jrieken added debt Code quality issues important Issue identified as high-priority labels Oct 4, 2017
@jrieken
Copy link
Member Author

jrieken commented Oct 4, 2017

I did assign folks based on searching for @types/ in all package.json files

@jrieken jrieken removed their assignment Oct 4, 2017
jrieken added a commit that referenced this issue Oct 4, 2017
@jrieken
Using strict version-id for @types-modules, #35561
bdbc992
aeschli added a commit that referenced this issue Oct 4, 2017
@aeschli
Use strict version-identifier for @types/xyz-modules . For #35561
12d4925
@aeschli
Copy link
Contributor

aeschli commented Oct 4, 2017

I updated html/json/css and the various task extensions (for @dbaeumer)

@aeschli aeschli removed their assignment Oct 4, 2017
@joaomoreno
Copy link
Member

Another idea is this: #35543 Thoughts?

@joaomoreno
Copy link
Member

Locked git deps.

joaomoreno added a commit that referenced this issue Oct 4, 2017
@joaomoreno
lock git @types deps
bb23d12 
related to #35561
@joaomoreno joaomoreno removed their assignment Oct 4, 2017
@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Oct 4, 2017 •
edited
Loading

emmet updated in master

ramya-rao-a added a commit that referenced this issue Oct 4, 2017
@ramya-rao-a
Use strict version-identifier for @types/node in emmet #35561
aafdfae
@ramya-rao-a ramya-rao-a removed their assignment Oct 4, 2017
@mjbvz mjbvz added this to the October 2017 milestone Oct 9, 2017
@mjbvz mjbvz closed this as completed in 0bd33bb Oct 9, 2017
sandy081 pushed a commit that referenced this issue Oct 16, 2017
@jrieken @sandy081
Using strict version-id for @types-modules, #35561
1e0cb7d
sandy081 pushed a commit that referenced this issue Oct 16, 2017
@aeschli @sandy081
Use strict version-identifier for @types/xyz-modules . For #35561
57bbac1
sandy081 pushed a commit that referenced this issue Oct 16, 2017
@joaomoreno @sandy081
lock git @types deps
b4e521a 
related to #35561
sandy081 pushed a commit that referenced this issue Oct 16, 2017
@ramya-rao-a @sandy081
Use strict version-identifier for @types/node in emmet #35561
f4edde0
sandy081 pushed a commit that referenced this issue Oct 16, 2017
@mjbvz @sandy081
Use strict versions for @types. Fixes #35561
0b04521
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 23, 2017
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
@mjbvz
Use strict versions for @types. Fixes microsoft#35561
8d94233
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
debt Code quality issues important Issue identified as high-priority
Projects
None yet
Milestone
October 2017
Development

No branches or pull requests
5 participants
@joaomoreno @jrieken @aeschli @mjbvz @ramya-rao-a