-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix terminal link tests #34193
Comments
@timbanaveen In order to fix a VS Code crash caused by a regex catastrophic backtracking case, I changed the unix link link regex (#34039). I had to disable some of the terminal link line/column Unix cases (added in #24832) as I don't totally understand what's happening. For some reason
See this change which gets 2/4 cases working: b411fb2 Any insights would be great 😃 |
@Tyriar, just saw this issue and fix. will have a detailed look in this on weekend, will update you on any findings. |
@timbanaveen did you get a chance to look at this? |
@Tyriar got new machine, i have just started setup. Will update soon. |
@Tyriar I tried running test from terminal using |
Hmm... I'm sure there is a way as it uses mocha, I'm not sure what it is though as the tests always run so fast for me. |
@Tyriar I have updated the tests and ts file, now tests are working fine. Please review. Thanks |
Disabled in 128a4e3
The text was updated successfully, but these errors were encountered: