Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCM: Explore master-detail view #33363

Closed
joaomoreno opened this issue Aug 29, 2017 · 5 comments
Closed

SCM: Explore master-detail view #33363

joaomoreno opened this issue Aug 29, 2017 · 5 comments
Assignees
Labels
feature-request Request for new features or functionality on-testplan scm General SCM compound issues ux User experience issues

Comments

@joaomoreno
Copy link
Member

From @sqs

Would you be interested in a PR that implemented a UI like this? I just hacked this together tonight.

The Open Repositories section works like the Open Editors section; it grows (to a point) based on the number of open repositories. Selecting a repository shows that repository's (and only that repository's) SourceControlView in the rest of the viewlet. Focus is in the Open Repositories list initially.

It would be fairly easy to make it possible to show multiple repositories' SourceControlViews if you multi-selected them. That would of course be duplicating some functionality of a viewlet's subviews (e.g., you could make it so right-clicking on the Source Control header would let you check/uncheck each repo, as in the extensions viewlet), but it seems quite convenient to make this always visible.

image

@joaomoreno joaomoreno added feature-request Request for new features or functionality scm General SCM compound issues labels Aug 29, 2017
@joaomoreno joaomoreno added this to the August 2017 milestone Aug 29, 2017
@joaomoreno joaomoreno self-assigned this Aug 29, 2017
@joaomoreno
Copy link
Member Author

Instead of multi select, we could use checkboxes for making them visible.

@bpasero
Copy link
Member

bpasero commented Aug 29, 2017

We actually had this design under consideration but did not pursue it any further because we did not easily want to add a new concept to the UI (master-detail view).

I personally always preferred a solution where I can pick the repository to the top and see changes below. I also think the master view should show the incoming/outgoing changes on each repository and maybe offer an action to synchronize.

/cc @stevencl @chrisdias

@stevencl
Copy link
Member

stevencl commented Sep 6, 2017

Yes, we had considered something similar to this early on (see the video here: https://www.youtube.com/watch?v=48Y6tB3DN1g&t=488s). One of the participants in this video makes the suggestion that we should show the list of repos, rather than the list of folders which is shown in the video which we agreed with.

I am not sure about the label 'Open repositories'. With the term 'open' being so prominent, it suggests that the user needs to manage (open and close) the repositories. Could it work if we just showed all the repos in the workspace as suggested in the video?

@joaomoreno
Copy link
Member Author

@stevencl Currently you can have even more repositories. For example, you can open a file outside any workspace, which lives in a git repo. We will show it.

Maybe we could use the term Active Repositories?

@joaomoreno
Copy link
Member Author

A first version of this was just pushed to master:

image

It basically works as a master-detail view, except it supports multi-select. If you only have a single repository, it should appear just as before, no section whatsoever.

Feedback welcome!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality on-testplan scm General SCM compound issues ux User experience issues
Projects
None yet
Development

No branches or pull requests

4 participants