Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Git: Allow closing git repositories #33341

Closed
joaomoreno opened this issue Aug 29, 2017 · 5 comments
Closed

Git: Allow closing git repositories #33341

joaomoreno opened this issue Aug 29, 2017 · 5 comments
Assignees
@joaomoreno
Labels
feature-request Request for new features or functionality git GIT issues
Milestone
August 2017

Comments

@joaomoreno
Copy link
Member

No description provided.

@joaomoreno joaomoreno added feature-request Request for new features or functionality git GIT issues labels Aug 29, 2017
@joaomoreno joaomoreno added this to the August 2017 milestone Aug 29, 2017
@joaomoreno joaomoreno self-assigned this Aug 29, 2017
This was referenced Aug 29, 2017
Closed
Closed
Closed
@weinand weinand added the verification-needed Verification of issue is requested label Aug 30, 2017
@jrieken
Copy link
Member

jrieken commented Aug 30, 2017

I this useful without persistence?

@joaomoreno
Copy link
Member Author

Yeah persistence is an interesting part of it... I keep going back to it but I don't yet have a good story for it. Maybe we make it workspace based? I'll leave that for next iteration.

@bpasero
Copy link
Member

bpasero commented Aug 31, 2017 •
edited
Loading

I can remove a repository, but it comes back right after. See this video:

panel-red

I also think that not persisting this somewhere is weird because you would always have to go back and close the repository.

@bpasero bpasero reopened this Aug 31, 2017
@bpasero bpasero added the verification-found Issue verification failed label Aug 31, 2017
@joaomoreno joaomoreno mentioned this issue Aug 31, 2017
Closed
@joaomoreno
Copy link
Member Author

Actually reverting this. I'll remove the Close command from git altogether. #33363 should either make it obsolete, or much easier to deal with. 👍

@joaomoreno joaomoreno reopened this Aug 31, 2017
@bpasero bpasero removed verification-found Issue verification failed verification-needed Verification of issue is requested labels Sep 1, 2017
@bpasero
Copy link
Member

bpasero commented Sep 1, 2017

Command is gone.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
feature-request Request for new features or functionality git GIT issues
Projects
None yet
Milestone
August 2017
Development

No branches or pull requests
4 participants
@joaomoreno @bpasero @jrieken @weinand