Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throttle tree provider refresh events #31191

Closed
jrieken opened this issue Jul 21, 2017 · 6 comments
Closed

Throttle tree provider refresh events #31191

jrieken opened this issue Jul 21, 2017 · 6 comments
Assignees
@sandy081
Labels
api bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority perf verified Verification succeeded
Milestone
July 2017

Comments

@jrieken
Copy link
Member

jrieken commented Jul 21, 2017

Extracted from #31123 (comment).
@vscodebot vscodebot bot added the api label Jul 21, 2017
@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug perf api and removed api labels Jul 21, 2017
@sandy081 sandy081 added this to the July 2017 milestone Jul 24, 2017
sandy081 added a commit that referenced this issue Jul 24, 2017
@sandy081
#31191 Use deboune event instead of delayer
57d7d9b
@ppggff
Copy link

ppggff commented Jul 25, 2017

It seems this commit break extension "patrys.vscode-code-outline" ? (Guess)
It cannot do refresh right now...

@sandy081
Copy link
Member

@ppggff Can you please file a separate issue with what is not working with the API with a sample to reproduce it.

@weinand
Copy link
Contributor

weinand commented Jul 25, 2017 •
edited
Loading

@sandy081 my loaded scripts explorer doesn't refresh any more.
Here is the code that has no effect anymore: https://github.com/Microsoft/vscode-node-debug/blob/master/src/node/extension/loadedScripts.ts#L41

I'm seeing this on macOS, but most likely this problem is platform independent.

@weinand weinand added the important Issue identified as high-priority label Jul 25, 2017
@sandy081 sandy081 reopened this Jul 25, 2017
@sandy081
Copy link
Member

Strange.. I had tests for refresh. Will see what caused it and fix it. Sorry for that.

@sandy081 sandy081 mentioned this issue Jul 25, 2017
Closed
@sandy081
Copy link
Member

My bad, It seems tree api does not support refreshing more than one element. I was calling refresh on more than one element.

@ppggff
Copy link

ppggff commented Jul 26, 2017

@sandy081 Fixed, thanks very much. Wait for updating...

@weinand weinand mentioned this issue Jul 26, 2017
Closed
@roblourens roblourens added the verified Verification succeeded label Aug 3, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
api bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority perf verified Verification succeeded
Projects
None yet
Milestone
July 2017
Development

No branches or pull requests
5 participants
@roblourens @jrieken @weinand @ppggff @sandy081