Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to the less invasive update UI and add an update reminder #29729

Closed
egamma opened this issue Jun 28, 2017 · 2 comments
Closed

Switch to the less invasive update UI and add an update reminder #29729

egamma opened this issue Jun 28, 2017 · 2 comments
Assignees
@joaomoreno
Labels
feature-request Request for new features or functionality install-update VS Code installation and upgrade system issues
Milestone
June 2017

Comments

@egamma
Copy link
Member

egamma commented Jun 28, 2017

We should push the update UI we were running on insiders to stable.

Since the new update notification UI is less invasive, there is the concern that users might forget to update and ignore the notification. Therefore we should add an update reminder, when a user did not update after a period of time. The proposal is to show the existing Update Available message box, when the user did not update after 5 days since the notification has appeared.
@egamma egamma added the install-update VS Code installation and upgrade system issues label Jun 28, 2017
@egamma egamma added this to the June 2017 milestone Jun 28, 2017
@joaomoreno joaomoreno added the feature-request Request for new features or functionality label Jun 28, 2017
joaomoreno added a commit that referenced this issue Jun 29, 2017
@joaomoreno
Revert "fixes #29729"
f00d4f7 
This reverts commit 1c86623.
joaomoreno added a commit that referenced this issue Jun 29, 2017
@joaomoreno
fixes #29729
a16f659
@joaomoreno joaomoreno reopened this Jun 29, 2017
@joaomoreno
Copy link
Member

Will be fixed by #29859

@joaomoreno
Copy link
Member

Fixed.

joaomoreno added a commit that referenced this issue Jun 30, 2017
@joaomoreno
Merge pull request #29859 from Microsoft/update-notification
e3c3d7c 
Fixes #29729
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
feature-request Request for new features or functionality install-update VS Code installation and upgrade system issues
Projects
None yet
Milestone
June 2017
Development

No branches or pull requests
2 participants
@joaomoreno @egamma