GitHub extension: private repository does not show any issues

[bpasero]

Refs: #29507

Steps to Reproduce:

1. open vscode-distro
2. do not set any username in settings

=> no issues are showing but there are 4 open in that repository

[chrmarti]

Is this without credentials manager, I guess?

[bpasero]

This was actually on Windows with the GitHub for Desktop dialog popping up, so I think I was connected properly.

[chrmarti]

Is this one of the dialogs asking for permission to share credentials with the running application?

[bpasero]

@chrmarti yeah exactly, and I get asked to enter my pin via SMS

[bpasero]

@chrmarti btw everything works fine for the vscode repository (after I validated my pin via SMS).

[chrmarti]

@bpasero It might work as it should then. The distro repository does not show any open issues assigned to you, the view should just show a single entry saying it did not find any issues in this case.

[bpasero]

@chrmarti yeah that is what I saw I think. I just thought that when I am not setting a user name in settings it would show issues from all users.

[chrmarti]

@bpasero It checks if the username it gets from the credentials manager is a valid username for that repository and then uses that. My hope was/is that most users will not need to configure anything to get useful results.

[bpasero]

@chrmarti ok got it, then maybe we can close this issue.

[chrmarti]

Maybe the message when no issues are found could be improved by mentioning for which username the query ran. That would clarify that there might well be other issues.