Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement selection inverting in the terminal again (or add terminal selection theme key) #28397

Closed
Tyriar opened this issue Jun 9, 2017 · 1 comment · Fixed by #33954
Closed

Implement selection inverting in the terminal again (or add terminal selection theme key) #28397

Tyriar opened this issue Jun 9, 2017 · 1 comment · Fixed by #33954
Assignees
@Tyriar
Labels
debt Code quality issues terminal General terminal issues that don't fall under another label
Milestone
September 2017

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 9, 2017

The new selection implementation removed the selection inverting feature from the terminal #28388

We should either add it back (xtermjs/xterm.js#692) or add a terminal selection background theme key.
@Tyriar Tyriar added debt Code quality issues terminal General terminal issues that don't fall under another label labels Jun 9, 2017
@Tyriar Tyriar added this to the June 2017 milestone Jun 9, 2017
@Tyriar Tyriar self-assigned this Jun 9, 2017
@Tyriar Tyriar closed this as completed in 435f1ef Jun 18, 2017
@Tyriar Tyriar added the verification-needed Verification of issue is requested label Jun 18, 2017
@Tyriar
Copy link
Member Author

Tyriar commented Jun 20, 2017

Reopening, after #29040 we may want to not allow theming of the selection until it's no longer a transparent color. See xtermjs/xterm.js#720

Might be best to remove the new theme key.

@Tyriar Tyriar reopened this Jun 20, 2017
@Tyriar Tyriar modified the milestones: Backlog, June 2017 Jun 23, 2017
Tyriar added a commit that referenced this issue Jun 23, 2017
@Tyriar
Remove terminal selection theme key for now
36ebaf5 
Part of #28397
@kieferrm kieferrm removed the verification-needed Verification of issue is requested label Aug 4, 2017
@Tyriar Tyriar modified the milestones: September 2017, Backlog Sep 10, 2017
@Tyriar Tyriar mentioned this issue Sep 10, 2017
Merged
Tyriar added a commit that referenced this issue Sep 10, 2017
@Tyriar
Support terminal.selectionBackground theme key
7df8d06 
Fixes #28397
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
debt Code quality issues terminal General terminal issues that don't fall under another label
Projects
None yet
Milestone
September 2017
Development

Successfully merging a pull request may close this issue.

Use canvas to render the terminal microsoft/vscode
2 participants
@Tyriar @kieferrm