Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support refactoring commands provided by TS Server #25739

Closed
RyanCavanaugh opened this issue May 1, 2017 · 6 comments · Fixed by #27166
Closed

Support refactoring commands provided by TS Server #25739

RyanCavanaugh opened this issue May 1, 2017 · 6 comments · Fixed by #27166
Assignees
@mjbvz
Labels
feature-request Request for new features or functionality typescript Typescript support issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
June 2017

Comments

@RyanCavanaugh
Copy link
Member

Logging this to track VS Code supporting the refactorings surfaced by microsoft/TypeScript#14624

I believe @mjbvz is on the case
@kieferrm kieferrm added typescript Typescript support issues feature-request Request for new features or functionality labels May 1, 2017
@mjbvz mjbvz added this to the May 2017 milestone May 1, 2017
@mjbvz mjbvz mentioned this issue May 5, 2017
Closed
1 task
@mjbvz
Copy link
Collaborator

mjbvz commented May 19, 2017

I believe the new ts refactoring PR is microsoft/TypeScript#15569

@mjbvz mjbvz modified the milestones: June 2017, May 2017 May 19, 2017
@RyanCavanaugh
Copy link
Member Author

Correct. Note command names have changed slightly from the original iteration

@mjbvz mjbvz mentioned this issue May 23, 2017
Merged
@kieferrm kieferrm mentioned this issue Jun 13, 2017
Closed
30 tasks
mjbvz added a commit to mjbvz/vscode that referenced this issue Jun 16, 2017
@mjbvz
Prototype TS/JS Refactoring Provider
dfadffe 
Fixes microsoft#25739, from microsoft/TypeScript#15569

Prototype of refactoring support for ts 2.4
mjbvz added a commit that referenced this issue Jun 16, 2017
@mjbvz
Prototype TS/JS Refactoring Provider (#27166)
1564137 
* Prototype TS/JS Refactoring Provider

Fixes #25739, from microsoft/TypeScript#15569

Prototype of refactoring support for ts 2.4

* Adding error reporting

* Updating for new API

* show quick pick for non-inlinable refactrings
@roblourens roblourens added the verification-needed Verification of issue is requested label Jun 27, 2017
@roblourens
Copy link
Member

@mjbvz How do I see these new refactorings? Can you give an example?

@mjbvz
Copy link
Collaborator

mjbvz commented Jun 28, 2017

There's currently only a single refactoring that I am aware of: convert es5 class to es6 class.

In a Js file, try something like:

function Foo(x) {
    this.x = x
}

new Foo(1)

and place the cursor over Foo to see the refactoring suggestion

@roblourens
Copy link
Member

That's what I was trying but I don't see it.

@roblourens roblourens added the verified Verification succeeded label Jun 28, 2017
@roblourens
Copy link
Member

roblourens commented Jun 28, 2017 •
edited
Loading

Works now ¯\(ツ)/¯

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
feature-request Request for new features or functionality typescript Typescript support issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
June 2017
Development

Successfully merging a pull request may close this issue.

Prototype TS/JS Refactoring Provider mjbvz/vscode
4 participants
@roblourens @kieferrm @RyanCavanaugh @mjbvz