Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

potential listener LEAK detected, having 175 listeners already #235256

Closed
alexr00 opened this issue Dec 4, 2024 · 1 comment · Fixed by #235305
Closed

potential listener LEAK detected, having 175 listeners already #235256

alexr00 opened this issue Dec 4, 2024 · 1 comment · Fixed by #235305
Assignees
@connor4312
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders testing Built-in testing support verified Verification succeeded
Milestone
November 2024

Comments

@alexr00
Copy link
Member

alexr00 commented Dec 4, 2024 

event.ts:902 Error
    at xhi.create (event.ts:933:15)
    at HKe.q [as onDidChange] (event.ts:1140:34)
    at new <anonymous> (testingExplorerView.ts:510:32)
    at rJe.oc (testingExplorerView.ts:498:26)
    at rJe.getActionViewItem (testingExplorerView.ts:334:17)
    at hJe.getActionViewItem (viewPaneContainer.ts:604:34)
    at n.getActionViewItem (panecomposite.ts:145:34)
    at yfe.Qb (compositePart.ts:466:32)
    at Object.actionViewItemProvider (compositePart.ts:408:54)
    at Object.actionViewItemProvider (toolbar.ts:113:29)

I'm seeing a lot of this while trying to test #210848 (comment)
@alexr00
Copy link
Member Author

alexr00 commented Dec 4, 2024

It's coming from this line:

vscode/src/vs/workbench/contrib/testing/browser/testingExplorerView.ts

Line 510 in aab1869

this._register(crService.onDidChange(() => {

@connor4312 connor4312 added bug Issue identified by VS Code Team member as probable bug testing Built-in testing support labels Dec 4, 2024
@connor4312 connor4312 added this to the November 2024 milestone Dec 4, 2024
connor4312 added a commit that referenced this issue Dec 4, 2024
@connor4312
testing: fix event listener leak in CR dropdown
7a93b81 
Fixes #235256
@connor4312 connor4312 mentioned this issue Dec 4, 2024
Merged
@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Dec 4, 2024
@vs-code-engineering vs-code-engineering bot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Dec 5, 2024
@alexr00 alexr00 added the verified Verification succeeded label Dec 5, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Jan 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@connor4312 connor4312

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders testing Built-in testing support verified Verification succeeded
Projects
None yet
Milestone
November 2024
Development

Successfully merging a pull request may close this issue.

testing: fix event listener leak in CR dropdown microsoft/vscode
2 participants
@connor4312 @alexr00