Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node-pty throws on arm64 product build #225355

Closed
Tyriar opened this issue Aug 11, 2024 · 1 comment · Fixed by #225412
Closed

node-pty throws on arm64 product build #225355

Tyriar opened this issue Aug 11, 2024 · 1 comment · Fixed by #225412
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug terminal-process Problems launching processes, managing ptys, exiting, process leaks, etc. upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream verified Verification succeeded vscode-build VS Code build process issues windows VS Code on Windows issues
Milestone
August 2024

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 11, 2024

When setting "terminal.integrated.experimental.windowsUseConptyDll": true on an arm64 machine:

image

Think I need to properly support npm_config_arch in node-pty
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug vscode-build VS Code build process issues windows VS Code on Windows issues terminal-process Problems launching processes, managing ptys, exiting, process leaks, etc. labels Aug 11, 2024
@Tyriar Tyriar added this to the August 2024 milestone Aug 11, 2024
@Tyriar Tyriar self-assigned this Aug 11, 2024
Tyriar added a commit to microsoft/node-pty that referenced this issue Aug 11, 2024
@Tyriar
Copy right dll/exe based on npm_config_arch
4f2f641 
Part of microsoft/vscode#224488
Part of microsoft/vscode#225355
@Tyriar Tyriar mentioned this issue Aug 11, 2024
Merged
@Tyriar
Copy link
Member Author

Tyriar commented Aug 11, 2024

microsoft/node-pty#704

@Tyriar Tyriar added upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream upstream-issue-fixed The underlying upstream issue has been fixed labels Aug 11, 2024
@Tyriar Tyriar mentioned this issue Aug 12, 2024
Merged
@Tyriar Tyriar closed this as completed in 22f6515 Aug 12, 2024
@connor4312 connor4312 added the verified Verification succeeded label Aug 29, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug terminal-process Problems launching processes, managing ptys, exiting, process leaks, etc. upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream verified Verification succeeded vscode-build VS Code build process issues windows VS Code on Windows issues
Projects
None yet
Milestone
August 2024
Development

Successfully merging a pull request may close this issue.

Update node-pty, use right binary on arm64 microsoft/vscode
2 participants
@Tyriar @connor4312