Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DECSCUSR 0 should reset to the user-defined cursorStyle #211394

Open
notpeelz opened this issue Apr 25, 2024 · 12 comments
Open

DECSCUSR 0 should reset to the user-defined cursorStyle #211394

notpeelz opened this issue Apr 25, 2024 · 12 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream
Milestone

Comments

@notpeelz
Copy link

notpeelz commented Apr 25, 2024

VS Code Version: 1.88.1
OS: Linux

Steps to Reproduce:

  1. Add "terminal.integrated.cursorStyle": "line" to your settings.json
  2. Run these commands in the integrated terminal:
printf "\033[4 q" # set cursor style to an underscore
printf "\033[0 q" # this should restore the cursor to the user-defined preference
printf "\033[ q"  # (this has the same effect as "0")
# ...but instead we end up with a "block" cursor

Relevant code: https://github.com/xtermjs/xterm.js/blob/2edc65baaa50f8b99c67f3df6f8d5d93c70a69e6/src/common/InputHandler.ts#L2732-L2738

Many popular terminals implement this behavior (e.g kitty, alacritty, Windows Terminal, ...)
More info on the topic: microsoft/terminal#7379

xterm issue: xtermjs/xterm.js#3293

@meganrogge meganrogge added upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream labels Apr 26, 2024
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label labels Apr 26, 2024
@Tyriar Tyriar added this to the Backlog milestone Apr 26, 2024
@Tyriar Tyriar added help wanted Issues identified as good community contribution opportunities good first issue Issues identified as good for first-time contributors labels Apr 26, 2024
@kevinc16
Copy link

kevinc16 commented May 3, 2024

Hey folks, I'm new to the codebase and wanted to start contributing, I took a quick look at the issue and seems like the fix is on the xterm side, is it ok if I work on this issue?

@kRaviteja7
Copy link

Hey folks, if the issue still open i would like to work this .

@kmr-ankitt
Copy link

Hey folks, I am new to opensource. Can i give it a try?

@gagan-bhullar-tech
Copy link

Hello, can i work on this.

@Tyriar
Copy link
Member

Tyriar commented Jun 21, 2024

If you'd like to work on this the fix will be in xterm.js: xtermjs/xterm.js#3293

@Arup-Chauhan
Copy link

Hi @Tyriar is anyone working on issue, if no I could work on this!

Or maybe anything similar, I am new to this repo and would be nice to get started, thanks in advance!

@Tyriar
Copy link
Member

Tyriar commented Jul 22, 2024

@Arup-Chauhan doesn't look like anyone's working on it. There's some good insight into how to do it here xtermjs/xterm.js#3293 (comment)

@Arup-Chauhan
Copy link

@Arup-Chauhan doesn't look like anyone's working on it. There's some good insight into how to do it here xtermjs/xterm.js#3293 (comment)

Great, so I will try and get started with it.
Please assign me the issue.

Also, can I make a draft PR for doing this issue? will mark it ready for review once the work is done.

@Tyriar
Copy link
Member

Tyriar commented Jul 22, 2024

@Arup-Chauhan we don't normally assign issues to external people but it's here that you're planning on working on it. Yes a draft PR is fine if you want some early feedback

@Arup-Chauhan
Copy link

@Arup-Chauhan we don't normally assign issues to external people but it's here that you're planning on working on it. Yes a draft PR is fine if you want some early feedback

Okay, that's very understandable.
Ill raise a draft PR.

I have a question already, asking there.

Arup-Chauhan added a commit to Arup-Chauhan/vscode that referenced this issue Jul 22, 2024
@alekcunn
Copy link

seems to work fine in native Ubuntu WSL. Just info for anyone working on it

@Arup-Chauhan
Copy link

Arup-Chauhan commented Aug 22, 2024

seems to work fine in native Ubuntu WSL.

Hi @alekcunn, thanks for the info, great help!

Just info for anyone working on it

I have a fix that I proposed on the xterm.js repo
I will start off by testing this on a Windows machine first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream
Projects
None yet
Development

No branches or pull requests

10 participants