-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DECSCUSR 0 should reset to the user-defined cursorStyle #211394
Comments
Hey folks, I'm new to the codebase and wanted to start contributing, I took a quick look at the issue and seems like the fix is on the |
Hey folks, if the issue still open i would like to work this . |
Hey folks, I am new to opensource. Can i give it a try? |
Hello, can i work on this. |
If you'd like to work on this the fix will be in xterm.js: xtermjs/xterm.js#3293 |
Hi @Tyriar is anyone working on issue, if no I could work on this! Or maybe anything similar, I am new to this repo and would be nice to get started, thanks in advance! |
@Arup-Chauhan doesn't look like anyone's working on it. There's some good insight into how to do it here xtermjs/xterm.js#3293 (comment) |
Great, so I will try and get started with it. Also, can I make a draft PR for doing this issue? will mark it ready for review once the work is done. |
@Arup-Chauhan we don't normally assign issues to external people but it's here that you're planning on working on it. Yes a draft PR is fine if you want some early feedback |
Okay, that's very understandable. I have a question already, asking there. |
Signed-off-by: Arup Chauhan <[email protected]>
seems to work fine in native Ubuntu WSL. Just info for anyone working on it |
Hi @alekcunn, thanks for the info, great help!
I have a fix that I proposed on the xterm.js repo |
VS Code Version: 1.88.1
OS: Linux
Steps to Reproduce:
"terminal.integrated.cursorStyle": "line"
to your settings.jsonRelevant code: https://github.com/xtermjs/xterm.js/blob/2edc65baaa50f8b99c67f3df6f8d5d93c70a69e6/src/common/InputHandler.ts#L2732-L2738
Many popular terminals implement this behavior (e.g kitty, alacritty, Windows Terminal, ...)
More info on the topic: microsoft/terminal#7379
xterm issue: xtermjs/xterm.js#3293
The text was updated successfully, but these errors were encountered: