Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal dotted underline is not pixel perfect #197254

Closed
Tyriar opened this issue Nov 2, 2023 · 0 comments · Fixed by #197257
Closed

Terminal dotted underline is not pixel perfect #197254

Tyriar opened this issue Nov 2, 2023 · 0 comments · Fixed by #197257
Assignees
@Tyriar
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal-rendering upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream verification-needed Verification of issue is requested verified Verification succeeded
Milestone
November 2023

Comments

@Tyriar
Copy link
Member

Tyriar commented Nov 2, 2023

xterm.js: xtermjs/xterm.js#4349
xterm.js PR: xtermjs/xterm.js#4703

image

To verify:

  1. On mac or linux
  2. echo -e "\x1b[4:4mdotted underline"
  3. Check to make sure the dots are perfectly spaced
  4. Resize to various zoom levels and check again
@Tyriar Tyriar added feature-request Request for new features or functionality terminal-rendering labels Nov 2, 2023
@Tyriar Tyriar added this to the November 2023 milestone Nov 2, 2023
@Tyriar Tyriar self-assigned this Nov 2, 2023
@Tyriar Tyriar added upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream upstream-issue-fixed The underlying upstream issue has been fixed labels Nov 2, 2023
Tyriar added a commit that referenced this issue Nov 2, 2023
@Tyriar
Update xterm
cdfecb4 
Fixes #197254
@Tyriar Tyriar mentioned this issue Nov 2, 2023
Merged
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 2, 2023
@Tyriar Tyriar added the verification-needed Verification of issue is requested label Nov 27, 2023
@andreamah andreamah added the verified Verification succeeded label Nov 28, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal-rendering upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
November 2023
Development

Successfully merging a pull request may close this issue.

Speed up xterm.js update script and update xterm.js microsoft/vscode
3 participants
@Tyriar @andreamah @vscodenpa