Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename --disable-keytar to --disable-persisted-secrets or similar #191498

Closed
TylerLeonhardt opened this issue Aug 28, 2023 · 1 comment · Fixed by #192312
Closed

Rename --disable-keytar to --disable-persisted-secrets or similar #191498

TylerLeonhardt opened this issue Aug 28, 2023 · 1 comment · Fixed by #192312
Assignees
@TylerLeonhardt
Labels
authentication Issues with the Authentication platform feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes verification-needed Verification of issue is requested verified Verification succeeded
Milestone
September 2023

Comments

@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Aug 28, 2023 •
edited
Loading

Follow up from #188432

We don't use keytar anymore, so we should rename this flag to something more generic:

  • --disable-persisted-secrets
  • --disable-secrets-storage
@TylerLeonhardt TylerLeonhardt self-assigned this Aug 28, 2023
@TylerLeonhardt TylerLeonhardt added feature-request Request for new features or functionality authentication Issues with the Authentication platform labels Aug 28, 2023
@TylerLeonhardt TylerLeonhardt added this to the Backlog milestone Aug 28, 2023
TylerLeonhardt added a commit that referenced this issue Sep 6, 2023
@TylerLeonhardt
Rename --disable-keytar to --use-inmemory-secretstorage
e5bb273 
This renames the flag as the title suggests but keeps `--disable-keytar` in the `deprecates` section so it still works.

Fixes #191498
@TylerLeonhardt TylerLeonhardt mentioned this issue Sep 6, 2023
Merged
TylerLeonhardt added a commit that referenced this issue Sep 8, 2023
@TylerLeonhardt
Rename --disable-keytar to --use-inmemory-secretstorage (#192312)
a4a2d8f 
This renames the flag as the title suggests but keeps `--disable-keytar` in the `deprecates` section so it still works.

Fixes #191498
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Sep 8, 2023
@rzhao271 rzhao271 modified the milestones: Backlog, September 2023 Sep 25, 2023
@TylerLeonhardt TylerLeonhardt added the verification-needed Verification of issue is requested label Sep 25, 2023
@TylerLeonhardt
Copy link
Member Author

Verification steps:

  • launch VS Code Insiders and log in to something
  • quit all VS Code Insiders (make sure it's completely quit on macOS)
  • code-insiders --disable-keytar you should see a warning that the command is deprecated and when VS Code Insiders launches you shouldn't be logged in
  • quit all VS Code Insiders (make sure it's completely quit on macOS)
  • code-insiders --use-inmemory-secretstorage you shouldn't see a warning and when VS Code Insiders launches you shouldn't be logged in
  • quit all VS Code Insiders (make sure it's completely quit on macOS)
  • launch VS Code Insiders normally. You should still be logged in to your stuff.

@sandy081 sandy081 added the verified Verification succeeded label Sep 26, 2023
@TylerLeonhardt TylerLeonhardt added the on-release-notes Issue/pull request mentioned in release notes label Sep 29, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TylerLeonhardt TylerLeonhardt

Labels
authentication Issues with the Authentication platform feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
September 2023
Development

Successfully merging a pull request may close this issue.

Rename --disable-keytar to --use-inmemory-secretstorage microsoft/vscode
4 participants
@TylerLeonhardt @rzhao271 @sandy081 @vscodenpa