Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Environment variable collection info not showing in single terminal tab #171498

Closed
Tyriar opened this issue Jan 17, 2023 · 2 comments · Fixed by #171500
Closed

Environment variable collection info not showing in single terminal tab #171498

Tyriar opened this issue Jan 17, 2023 · 2 comments · Fixed by #171500
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-tabs verified Verification succeeded
Milestone
January 2023

Comments

@Tyriar
Copy link
Member

Tyriar commented Jan 17, 2023 •
edited
Loading

Repro:

  • Activate terminal-sample from vscode-extension-samples
  • Open a terminal
  • Type in it
  • Run the "Update environment" command

Actual when there is a single terminal tab:

image

Expected to see this message:

image
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal-tabs labels Jan 17, 2023
@Tyriar Tyriar added this to the January 2023 milestone Jan 17, 2023
@Tyriar Tyriar mentioned this issue Jan 17, 2023
Closed
@DanTup
Copy link
Contributor

DanTup commented Jan 17, 2023

@Tyriar it's not clear to me from the second screenshot above how the user "fixes" the issue. It says an extension wants to change the environment variables, but it doesn't seem like there's any button/link to click to do that?

Tyriar added a commit that referenced this issue Jan 17, 2023
@Tyriar
Show env var info in single tab
992f45a 
Fixes #171498
@Tyriar Tyriar mentioned this issue Jan 17, 2023
Merged
@Tyriar
Copy link
Member Author

Tyriar commented Jan 17, 2023

@DanTup looks like we regressed and the actions no longer show up:

image

I'll fix in #171500

FYI @rzhao271

@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 17, 2023
@Tyriar Tyriar added the verified Verification succeeded label Jan 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-tabs verified Verification succeeded
Projects
None yet
Milestone
January 2023
Development

Successfully merging a pull request may close this issue.

Show env var info in single tab microsoft/vscode
4 participants
@DanTup @Tyriar @meganrogge @vscodenpa