Terminal rendering issues in Codespaces (iPadOS)

[alefragnani]

Does this issue occur when all extensions are disabled?: Yes/No

• VS Code Version: 1.73 - Codespaces / Insiders release
• OS Version: iPadOS 15.7

Steps to Reproduce:

1. Open a Codespaces
2. Be sure to be using the Insiders Release
3. Toggle Terminal
4. The terminal rendering is unstable. Sometimes it only displays the username, sometimes is empty, and very few times it displays the entire shell (username / path / git branch)
5. Create a new Terminal using the Terminal: Create New Terminal command
6. A new terminal is created, but the same rendering issue occurs.
7. You can repeat step 4 as many times as you want, and the same issue in step 5 will happen every time
8. Type some command inside the terminal area
9. You won’t see the keys you pressed, but hitting enter, you will notice the command itself was sent, because you can see the decorator at the right of the terminal area that refers to the new shell entry, as the picture below

Switching to Stable version you won’t see such issue.

Thank you

[meganrogge]

@rebornix could you pls see if you can repro ? I don't have an ipad

[marchellll]

It may not a problem with Codespaces, but the iPadOS. I am using code-server and got the same issue.

[meganrogge]

Disabling terminal.integrated.gpuAcceleration should fix this. the console log from dev tools would be helpful

[alefragnani]

Disabling gpuAcceleration ("terminal.integrated.gpuAcceleration": "off") indeed fix the terminal issue, thanks!

I wonder what does the Insiders release has that raises this issue, but it's good to know you found that, and probably is aware which feature is responsible for.

Thank you

[alefragnani]

Not sure which piece of the console log you are looking for, but I noticed a different error message popping up when the gpuAcceleration is enabled.

Is that helpful?

ps: a few more details about the iPad itself. Not sure it makes any difference

• 8th gen iPad (10.2")
• Smart Keyboard
• Safari browser

[Tyriar]

Very helpful, not sure right now how that could happen though. Code it's pointing at: https://github.com/xtermjs/xterm.js/blob/1b13127f0be68b7e4b1a6c71717c74f503ff783d/addons/xterm-addon-canvas/src/BaseRenderLayer.ts#L374-L384

[Tyriar]

Sigh... https://bugs.webkit.org/show_bug.cgi?id=149990

[Tyriar]

Tracking upstream: xtermjs/xterm.js#4218

[alefragnani]

Any idea why this is happening only in the Insiders? Because the
gpuAcceleration doesn't seems to be exclusive to Insiders.

[Tyriar]

@alefragnani the canvas renderer just got a major refactor to share a lot of code with the webgl renderer.

[vscodenpa]

This bug has been fixed in the latest release of VS Code Insiders!

@alefragnani, you can help us out by commenting /verified if things are now working as expected.

If things still don't seem right, please ensure you're on version 9ad0693 of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!

[meganrogge]

@rebornix can you try to verify this on your ipad?

[alefragnani]

Hi, I just tested and the issue remains.

I’ll try again tomorrow, and post the updates here.

Thank you

[Tyriar]

We may need a check like this somewhere for canvas too?

https://github.com/xtermjs/xterm.js/blob/452241ca9207506b8fb850b3062e5b4dbcf568a4/addons/xterm-addon-webgl/src/WebglAddon.ts#L36-L38

I don't totally understand what's going on here and don't have an iPad.

[jet082]

This is marked as a duplicate of #144232, but is that really the case? This seems to be about graphical rendering whereas #144232 is about input problems. I would leave a comment there, but it is closed to contributions. I propose that is reopened and this issue is kept to the rendering issues.

[Tyriar]

@jet082 I reopened and unlocked it

[Tyriar]

The canvas renderer has been removed from xterm.js/vscode, so this is no longer relevant 🎉