Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test built-in audio/video preview #161823

Closed
3 tasks done
mjbvz opened this issue Sep 26, 2022 · 7 comments
Closed
3 tasks done

Test built-in audio/video preview #161823

mjbvz opened this issue Sep 26, 2022 · 7 comments

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Sep 26, 2022

Test for #159106

Complexity: 4

Create Issue


Summary

We now include a basic preview for audio and video files. For this test plan item, test out the basic functionality of these new previews

Testing

  • Try opening audio files in VS Code

    The following formats should work: mp3, wav, ogg

  • Try opening a video file in VS Code

    The following formats should work: mp4, webm

Both of these previews use Chrome's built-in controls. This limits our ability to customize and theme. I opted to use these controls so we don't have to maintain our own code here. They also match how other video/audio files are rendered in VS Code (such as in notebooks)

@mjbvz mjbvz added this to the September 2022 milestone Sep 26, 2022
@ghost ghost assigned lszomoru, amunger and andreamah Sep 27, 2022
@usernamehw
Copy link
Contributor

.opus doesn't work. It seems like they are not in the list of added codecs #156558 (comment)

@amunger
Copy link
Contributor

amunger commented Sep 27, 2022

webm and .opus both just have an error messsage when attempting to open on Windows (screenshot). and mp4 does not have audio available (linked issue)

image

@amunger amunger removed their assignment Sep 27, 2022
@mjbvz
Copy link
Collaborator Author

mjbvz commented Sep 27, 2022

@usernamehw Thanks. Yes should be ogg instead of opus

@mjbvz
Copy link
Collaborator Author

mjbvz commented Sep 27, 2022

@amunger webm works for me. Can you please share the file that doesn't work:

Screen Shot 2022-09-27 at 1 48 56 PM

@amunger
Copy link
Contributor

amunger commented Sep 27, 2022

sample_960x540.webm

@mjbvz
Copy link
Collaborator Author

mjbvz commented Sep 27, 2022

@amunger Thanks. The issue is that the video from your example is vp9, while we only support vp8 (the example I tested was using vp8)

webm is a container format, which makes it hard for us to know if the video will actually be supported as or not until we try opening it

@amunger
Copy link
Contributor

amunger commented Sep 28, 2022

✅ .ogg

@lszomoru lszomoru removed their assignment Sep 28, 2022
@rzhao271 rzhao271 assigned rzhao271 and unassigned andreamah and rzhao271 Sep 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants