-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test built-in audio/video preview #161823
Comments
|
@usernamehw Thanks. Yes should be |
@amunger webm works for me. Can you please share the file that doesn't work: |
sample_960x540.webm |
@amunger Thanks. The issue is that the video from your example is vp9, while we only support vp8 (the example I tested was using vp8)
|
✅ .ogg |
Test for #159106
Complexity: 4
Create Issue
Summary
We now include a basic preview for audio and video files. For this test plan item, test out the basic functionality of these new previews
Testing
Try opening audio files in VS Code
The following formats should work: mp3, wav, ogg
Try opening a video file in VS Code
The following formats should work: mp4, webm
Both of these previews use Chrome's built-in controls. This limits our ability to customize and theme. I opted to use these controls so we don't have to maintain our own code here. They also match how other video/audio files are rendered in VS Code (such as in notebooks)
The text was updated successfully, but these errors were encountered: