Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proprietary codecs to FFmpeg #156558

Closed
3 tasks done
isidorn opened this issue Jul 28, 2022 · 4 comments · Fixed by #158486
Closed
3 tasks done

Add proprietary codecs to FFmpeg #156558

isidorn opened this issue Jul 28, 2022 · 4 comments · Fixed by #158486
Assignees
Labels
insiders-released Patch has been released in VS Code Insiders on-testplan plan-item VS Code - planned item for upcoming
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Jul 28, 2022

Add the following codecs to our FFmpeg version:

  • H.264
  • VP8
  • VP9
  • AAC
  • WAV
  • MP3
  • Opus

This would fix #118275 and #147190

Work to be done (roughly):

  • Get legal review and approval
  • Create electron version with all the codecs
  • Self host a full milestone on it
@isidorn isidorn added the plan-item VS Code - planned item for upcoming label Jul 28, 2022
@isidorn isidorn added this to the August 2022 milestone Jul 28, 2022
@joaomoreno joaomoreno changed the title Add proprietary codecs to our FFmpeg Add proprietary codecs to FFmpeg Jul 28, 2022
@isidorn
Copy link
Contributor Author

isidorn commented Aug 12, 2022

We got approval to ship the following:

  • Vorbis
  • Flac
  • H.264
  • VP8
  • WAV
  • MP3
  • Ogg

@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 18, 2022
@isidorn isidorn mentioned this issue Aug 22, 2022
3 tasks
@dmalan
Copy link

dmalan commented Aug 24, 2022

Thank you for this! Especially helpful for educational use cases like embedding instructional videos in Markdown files!

@isidorn
Copy link
Contributor Author

isidorn commented Aug 24, 2022

@dmalan welcome! Once you try it out do let us know how it works in practice. Since we do not support all the popular codecs we hope that the current list will give you enough flexibility.

@rajkundu
Copy link

This works great! It is a huge boon for computer vision applications such as mine, where I am continuously processing, analyzing, and re-rendering videos. The only hiccup I've encountered is the fact that OpenCV, a very popular library for computer vision, unfortunately doesn't support H.264 encoding due to some licensing issues. However, there are workarounds and other libraries.

Regardless, thank you very, very much for this! 😄

@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
insiders-released Patch has been released in VS Code Insiders on-testplan plan-item VS Code - planned item for upcoming
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants