Terminal performance is down

[abhijit-chikane]

Does this issue occur when all extensions are disabled?: Yes

• VS Code Version:1.70
• OS Version: windows 10

Steps to Reproduce:

1. After I upgrade the vscode to 1.70 version it's terminal is seems performing slowly

[vscodenpa]

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.70.0. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!

[meganrogge]

Please see https://github.com/Microsoft/vscode/wiki/Performance-Issues for creating actionable performance problem issues.
/label info-needed terminal

[tinydogio-joshua]

My team has been seeing a large slow down with the terminal when in a devcontainer's main project directory. It's fast once you leave it.

[tinydogio-joshua]

I just tried disabling newly enabled shellIntegration setting and it sped back up.

"terminal.integrated.shellIntegration.enabled": false

https://code.visualstudio.com/updates/v1_70#_terminal

---

Operating System: macOS 12.5
Hardware: MacBook Pro 13-inch, M1, 2020) 16 GB Memory
Visual Studio Code: Version 1.70.0 Universal

[Tyriar]

@abhijitchikane @tinydogio-joshua what shell are you using?

[tinydogio-joshua]

zsh. My team is all on M1 MacBook Pro's. One person has oh-my-zsh installed. I have rocketship. The rest are stock. This is in a decent sized monorepo in a Node+TypeScript devcontainer. The same behavior does not appear in the stock/empty Node+TypScript devcontainer. I have not tried it locally (outside the container) as we don't work that way.

[Tyriar]

@tinydogio-joshua adding your comment from microsoft/vscode-remote-release#6986 for more context:

@tinydogio-joshua can you be more specific what you mean by "a lot of delays"? Also what shell were you using?

We were seeing 3 to 10 second delays typing in pretty much any command. We're all on M1 MacBook Pro's. zsh shell. I know at least one person has oh-my-zsh installed. I have rocketship but as far as I know the rest of the team hasn't customized their shells. Setting the above setting to false brought the performance back up.

It is in a decent sized monorepo. Doing a stock/empty Node+TypeScript devcontainer does not show the same behavior.

[WindSoilder]

I get the similar performance issue, using nushell, with MacBook Pro (not M1)

[jakebailey]

I'm also having bad performance with the new shellIntegration enabled with powershell on Windows 11; it manifests as a huge delay to focus the terminal, or the whole editor freezing and asking if I want to restart it, or, not even being able to launch a new terminal (the pane is blank). Sometimes when it happens, Code.exe is using a large amount of CPU.

The main problem is that it's intermittent and I can't seem go get a profile of it... but I'm trying.

[Tyriar]

I fixed several performance regressions in the last few days: xtermjs/xterm.js#4080, xtermjs/xterm.js#4081, xtermjs/xterm.js#4084. I expect this to be fixed in v1.72 (September)

[mjbvz]

@Tyriar Can you please provides steps to verify this?

[Tyriar]

This is a bit hard to verify, but myself and @jerch have already tested it fairly thoroughly

[iansimonson]

Just commenting to give anecdotal data. In 1.72.0 the example I gave in the duplicate issue #159476 now renders in 12-15 seconds depending on the run for an 11.8 second run with lots of text. Previously it was rendering in 39.7 seconds.

The integrated terminal is definitely usable again, thanks! (at least on my box 😄 )