Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The manage workspace trust tab icon seems large/misaligned #152509

Closed
Tyriar opened this issue Jun 17, 2022 · 2 comments · Fixed by #152904
Closed

The manage workspace trust tab icon seems large/misaligned #152509

Tyriar opened this issue Jun 17, 2022 · 2 comments · Fixed by #152904
Assignees
@sbatten
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded workspace-trust Trusted workspaces
Milestone
June 2022

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 17, 2022

Not much padding between it and the word:

image
image
@miguelsolorio
Copy link
Contributor

miguelsolorio commented Jun 17, 2022 •
edited
Loading

Passing to @aeschli as this is a file icon but in the icon we actually have it designed at 14px scale (and offset to avoid pixelation) and i know the file icons use different scaling styles

CleanShot 2022-06-17 at 12 33 56@2x

@aeschli
Copy link
Contributor

aeschli commented Jun 20, 2022 •
edited
Loading

The trust editor uses a product icon (codicon) as editor icon here:
https://github.com/Microsoft/vscode/blob/main/src/vs/workbench/contrib/workspace/browser/media/workspaceTrustEditor.css#L8
I think this needs to be adjusted there.

@aeschli aeschli assigned sbatten and unassigned aeschli and miguelsolorio Jun 20, 2022
@sbatten sbatten added bug Issue identified by VS Code Team member as probable bug workspace-trust Trusted workspaces labels Jun 21, 2022
@sbatten sbatten added this to the June 2022 milestone Jun 21, 2022
@sbatten sbatten mentioned this issue Jun 22, 2022
Merged
sbatten added a commit that referenced this issue Jun 22, 2022
@sbatten
fixes #152509
dcf47e5
sbatten added a commit that referenced this issue Jun 22, 2022
@sbatten
fixes #152509 (#152904)
3997bb7
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 22, 2022
@Tyriar Tyriar added the verified Verification succeeded label Jun 29, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sbatten sbatten

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded workspace-trust Trusted workspaces
Projects
None yet
Milestone
June 2022
Development

Successfully merging a pull request may close this issue.

fixes #152509 microsoft/vscode
5 participants
@Tyriar @aeschli @sbatten @miguelsolorio @vscodenpa