Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial build task launch takes a long time to launch #142413

Closed
Tyriar opened this issue Feb 7, 2022 · 4 comments
Closed

Initial build task launch takes a long time to launch #142413

Tyriar opened this issue Feb 7, 2022 · 4 comments
Assignees
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders tasks Task system issues verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 7, 2022

For this tasks.json https://github.com/xtermjs/xterm.js/blob/master/.vscode/tasks.json

I waited a bit after startup to ensure everything settled down, the lines represent:

  • Blue: Status bar item appears
  • Red: Status bar item goes away (800ms later)
  • Green: Terminals are created (2 seconds later)

image

Profile:

Profile-20220207T074700.zip

@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug tasks Task system issues labels Feb 7, 2022
@alexr00 alexr00 added this to the February 2022 milestone Feb 7, 2022
@alexr00
Copy link
Member

alexr00 commented Feb 7, 2022

Most of the gap is coming from resolving dependsOn tasks, where we fetch all tasks to find the matching dependsOn task. This can be improved.

@alexr00 alexr00 closed this as completed in e5bf0ee Feb 8, 2022
@alexr00
Copy link
Member

alexr00 commented Feb 8, 2022

Faster resolving of dependsOn tasks requires two things:

@connor4312 connor4312 added the author-verification-requested Issues potentially verifiable by issue author label Feb 25, 2022
@Tyriar
Copy link
Member Author

Tyriar commented Feb 25, 2022

Much faster when label is set 👍

@alexr00 anyway to avoid needing the label? Most people won't end up getting the performance benefit because of that.

@Tyriar Tyriar added the verified Verification succeeded label Feb 25, 2022
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Feb 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders tasks Task system issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants
@Tyriar @connor4312 @alexr00 and others