Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor - Bring back getModeAtPosition() semantics #14136

Closed
3 of 4 tasks
egamma opened this issue Oct 21, 2016 · 2 comments
Closed
3 of 4 tasks

Editor - Bring back getModeAtPosition() semantics #14136

egamma opened this issue Oct 21, 2016 · 2 comments
Assignees
@alexdima
Labels
feature-request Request for new features or functionality
Milestone
October 2016

Comments

@egamma
Copy link
Member

egamma commented Oct 21, 2016 •
edited by alexdima
Loading

Since we extracted HTML into an extension, getModeAtPosition always returns the top-level mode/language and not the nested one.

TODO:

  • determine language based on top level scopes for each token
  • generate modeTransitions based on the token's language transition
  • somehow load embedded languages configurations
  • write test plan item
@egamma egamma added the editor label Oct 21, 2016
@egamma egamma added this to the October 2016 milestone Oct 21, 2016
alexdima added a commit that referenced this issue Oct 24, 2016
@alexdima
Introduce TMScopeRegistry (#14136)
3d84119
alexdima added a commit that referenced this issue Oct 24, 2016
@alexdima
Adopt TMScopeRegistry and improve tests (#14136)
7a90911
alexdima added a commit that referenced this issue Oct 24, 2016
@alexdima
Record language for each seen scope (#14136)
3cc0817
alexdima added a commit that referenced this issue Oct 24, 2016
@alexdima
Fix issue in scopeToLanguage (#14136)
eea2028
alexdima added a commit that referenced this issue Oct 24, 2016
@alexdima
Extract & add tests for decodeTextMateTokens (#14136)
6790d0a
alexdima added a commit that referenced this issue Oct 24, 2016
@alexdima
Prepare decodeTextMateToken for returning modeId (#14136)
8a45895
alexdima added a commit that referenced this issue Oct 24, 2016
@alexdima
Generate mode transitions from TM tokenizer (#14136)
86b2e52
@alexdima alexdima mentioned this issue Oct 24, 2016
Closed
@alexdima alexdima added the feature-request Request for new features or functionality label Oct 24, 2016
@aeschli
Copy link
Contributor

aeschli commented Oct 24, 2016

Once fixed, I guess #11081 can be closed

alexdima added a commit that referenced this issue Oct 24, 2016
@alexdima
Trigger loading configuration for embedded modes
b62ca81 
Load configuration for languages when they are first encountered as an embedded mode in TextMate (#14136)
@alexdima alexdima mentioned this issue Oct 24, 2016
Closed
@alexdima
Copy link
Member

Test coverage will be done through verification of issue #11081 and all linked issues from there.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
feature-request Request for new features or functionality
Projects
None yet
Milestone
October 2016
Development

No branches or pull requests
3 participants
@egamma @alexdima @aeschli