-
Notifications
You must be signed in to change notification settings - Fork 29.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt injected text infrastructure for other features #132537
Comments
@hediet can you clarify what other features will be looked at for this? |
Mainly the test explorer I think. The scope of this issue is flexible and part of it is figuring out where injected text makes sense (instead of before/after css text). |
::before
and ::after
in the editor
::before
and ::after
in the editor
Injected text semantics currently do not make much sense for Alex thoughts:
We decided to adopt injected text for |
Users of
IModelDecorationOptions.beforeContentClassName
orIModelDecorationOptions.afterContentClassName
:breakpointEditorContribution.ts#L103
breakpointEditorContribution.ts#L136
:callStackEditorContribution.ts#L83
⋯
at end of folded linesUsers of
IThemeDecorationRenderOptions.before
orIThemeDecorationRenderOptions.after
:Users of
IThemeDecorationRenderOptions.beforeInjectedText
orIThemeDecorationRenderOptions.afterInjectedText
:inlayHintsController.ts#L249
Users of
IThemeDecorationInstanceRenderOptions.after
:breakpointWidget.ts#L70
debugEditorContribution.ts#L89
repl.ts#L693
interactiveEditor.ts#L574
commentThreadWidget.ts#L855
Sample showing how we could render a color box:
The text was updated successfully, but these errors were encountered: