Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking issue from output of GitHub Issues notebook loses blue border around focused cell #111663

Closed
bamurtaugh opened this issue Dec 1, 2020 · 4 comments
Assignees
Labels
debt Code quality issues notebook-rendering ux User experience issues
Milestone

Comments

@bamurtaugh
Copy link
Member

Testing #111552, with a closer look at last checked item in #109549 (clicking on an issue in cell output and navigating back to VS Code).

Focus on a cell and run it:

image

Click on an issue from its output

Return to VS Code, looks like focus on the cell was lost:

image

However, I tried changing language mode, and it successfully picked up that cell and changed it to markdown:

image

Could we indicate focus on this cell (/when users interact with or click on the output area) in some way? i.e. still include the blue border around the cell, or some sort of border/shading around the output?

@miguelsolorio
Copy link
Contributor

miguelsolorio commented Dec 1, 2020

@rebornix we seem to add a class cell-output-hover on cell-inner-container when hovering on the cell output. If we could add a similar class for when the output has focus, we can tweak the focus rules and give the cell focus.

@rebornix rebornix added notebook ux User experience issues labels Dec 2, 2020
@rebornix rebornix added this to the December/January 2021 milestone Dec 2, 2020
@rebornix rebornix modified the milestones: January 2021, February 2021 Jan 28, 2021
@rebornix rebornix added the debt Code quality issues label Jan 28, 2021
@rebornix rebornix modified the milestones: March 2021, April 2021 Mar 25, 2021
@rebornix rebornix added the important Issue identified as high-priority label Mar 25, 2021
rebornix added a commit that referenced this issue Mar 29, 2021
@rebornix
Copy link
Member

@misolori I added the output focus class, anything else we need 412f45f ?

@miguelsolorio miguelsolorio modified the milestones: April 2021, May 2021 Apr 27, 2021
@rebornix rebornix modified the milestones: May 2021, On Deck Jun 4, 2021
@rebornix rebornix removed the important Issue identified as high-priority label Aug 4, 2021
@daviddossett daviddossett removed their assignment Dec 6, 2022
@rebornix
Copy link
Member

rebornix commented Dec 7, 2022

Fixed now.

@rebornix rebornix closed this as completed Dec 7, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues notebook-rendering ux User experience issues
Projects
None yet
Development

No branches or pull requests

7 participants
@rebornix @DonJayamanne @tanhakabir @daviddossett @bamurtaugh @miguelsolorio and others