Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open notebook when diff editor is open doesn't the file in notebook editor #110894

Closed
rebornix opened this issue Nov 18, 2020 · 1 comment
Closed

Open notebook when diff editor is open doesn't the file in notebook editor #110894

rebornix opened this issue Nov 18, 2020 · 1 comment
Assignees
@rebornix
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook verified Verification succeeded
Milestone
November 2020

Comments

@rebornix
Copy link
Member

Extracted from #109549

Steps to Reproduce:

  1. Open a GitHub issue notebook
  2. Modify it, close
  3. Open from the scm viewlet
  4. After the diff view is opened, cmd+p, and open the file again from the command palette
  5. Now the file is opened in a json editor, however it should be opened in a notebook editor

Does this issue occur when all extensions are disabled?: Yes/No
@rebornix rebornix self-assigned this Nov 18, 2020
@rebornix rebornix added bug Issue identified by VS Code Team member as probable bug notebook labels Nov 18, 2020
@rebornix rebornix added this to the November 2020 milestone Nov 18, 2020
@rebornix rebornix mentioned this issue Nov 18, 2020
Closed
13 tasks
chenjigeng pushed a commit to chenjigeng/vscode that referenced this issue Nov 22, 2020
@rebornix
fix microsoft#110894
9e5ea4f
@rzhao271 rzhao271 added the verified Verification succeeded label Dec 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jan 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook verified Verification succeeded
Projects
None yet
Milestone
November 2020
Development

No branches or pull requests
3 participants
@rebornix @rzhao271 and others