Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings editor accessibility improvements #106897

Closed
9 tasks done
roblourens opened this issue Sep 16, 2020 · 0 comments
Closed
9 tasks done

Settings editor accessibility improvements #106897

roblourens opened this issue Sep 16, 2020 · 0 comments
Assignees
@roblourens
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality on-testplan settings-editor VS Code settings editor issues
Milestone
September 2020

Comments

@roblourens
Copy link
Member

roblourens commented Sep 16, 2020 •
edited
Loading

Continuing #104318, we have selected "option A" and intend to ship it in September

Current TODO list

  • Clean up aria labels that cause setting name and description to be read a second time when the control is focused
  • UI cleanup, check default row selection colors
  • Do something with selection highlight for the full settings list, which doesn't look right
  • Fix "escape" in the search input to clear the input
  • Code cleanup around tabindex hacking
  • Focus a row when the control is focused via click
  • Fix shift+F9 keybinding when control is not selected
  • Fix table of contents sometimes disappearing
  • Down arrow when dropdown is selected should open the dropdown, not change list focus
@roblourens roblourens added feature-request Request for new features or functionality accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues settings-editor VS Code settings editor issues labels Sep 16, 2020
@roblourens roblourens added this to the September 2020 milestone Sep 16, 2020
@roblourens roblourens self-assigned this Sep 16, 2020
@roblourens roblourens mentioned this issue Sep 16, 2020
Closed
roblourens added a commit that referenced this issue Sep 23, 2020
@roblourens
Clean up settings editor aria label code #106897
41a7b46
roblourens added a commit that referenced this issue Sep 23, 2020
@roblourens
Add modified and "also modified in" text to setting row aria label - #…
8c2e1bf 
…106897
roblourens added a commit that referenced this issue Sep 23, 2020
@roblourens
Fix clicking description to toggle checkbox - #106897
49225a4
roblourens added a commit that referenced this issue Sep 23, 2020
@roblourens
Tweak coloring and spacing in new settings editor #106897
0405841
@roblourens roblourens mentioned this issue Sep 23, 2020
Closed
roblourens added a commit that referenced this issue Sep 23, 2020
@roblourens
Don't hide settings tree focus border under toc #106897
252bef0
@roblourens roblourens mentioned this issue Sep 24, 2020
Closed
roblourens added a commit that referenced this issue Sep 24, 2020
@roblourens
Clean up dead aria-label code #106897
896fb66
roblourens added a commit that referenced this issue Sep 24, 2020
@roblourens
Clicking setting control should focus the row #106897
65e7a94
@roblourens roblourens mentioned this issue Sep 24, 2020
Closed
roblourens added a commit that referenced this issue Sep 27, 2020
@roblourens
Fix showing setting context menu with keybinding #106897
2ecd0c6
roblourens added a commit that referenced this issue Sep 27, 2020
@roblourens
Fix restoring focus to setting row vs control #106897
e96516c
roblourens added a commit that referenced this issue Sep 27, 2020
@roblourens
Fix "enter" to focus control on complex settings #106897
c5bbe57
roblourens added a commit that referenced this issue Sep 27, 2020
@roblourens
Add "focus level up" command to clean up "escape" behavior on setting…
832725b 
…s editor #106897
roblourens added a commit that referenced this issue Sep 28, 2020
@roblourens
Clean up tabindex hacking to control tab behavior on settings editor #…
6e51ec0 
…106897
@roblourens roblourens mentioned this issue Sep 28, 2020
Closed
3 tasks
roblourens added a commit that referenced this issue Sep 28, 2020
@roblourens
Move toc outline color registration #106897
81d2883
roblourens added a commit that referenced this issue Sep 28, 2020
@roblourens
Custom dropdown should always stop key event propagation when the key…
645c490 
…press is handled #106897

Fix using arrow keys on dropdown in settings editor
meganrogge pushed a commit that referenced this issue Oct 1, 2020
@roblourens @meganrogge
Clean up tabindex hacking to control tab behavior on settings editor #…
aac93f4 
…106897
meganrogge pushed a commit that referenced this issue Oct 1, 2020
@roblourens @meganrogge
Move toc outline color registration #106897
3f0523a
meganrogge pushed a commit that referenced this issue Oct 1, 2020
@roblourens @meganrogge
Custom dropdown should always stop key event propagation when the key…
cfaa3e6 
…press is handled #106897

Fix using arrow keys on dropdown in settings editor
@roblourens roblourens mentioned this issue Oct 2, 2020
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality on-testplan settings-editor VS Code settings editor issues
Projects
None yet
Milestone
September 2020
Development

No branches or pull requests
1 participant
@roblourens