Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show number of filtered debug console items #105866

Closed
roblourens opened this issue Sep 1, 2020 · 9 comments · Fixed by #107067
Closed

Show number of filtered debug console items #105866

roblourens opened this issue Sep 1, 2020 · 9 comments · Fixed by #107067
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded

Comments

@roblourens
Copy link
Member

Testing #105185

Just another feature request. It would be useful to see how many debug console items are filtered out. Especially if I see this number going up, then I know I am missing new messages.

@isidorn
Copy link
Contributor

isidorn commented Sep 1, 2020

Yeah great idea. I think this could be shown in the filter area.
This could be a shared experience also in the Problems view @sandy081

I am opening this up for PRs.
Code pointer

export class ReplFilter implements ITreeFilter<IReplElement> {

@isidorn isidorn added debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality labels Sep 1, 2020
@isidorn isidorn added this to the Backlog milestone Sep 1, 2020
@isidorn isidorn added the help wanted Issues identified as good community contribution opportunities label Sep 1, 2020
@sandy081
Copy link
Member

sandy081 commented Sep 2, 2020

@isidorn FYI, problems view already show this like below

image

@isidorn
Copy link
Contributor

isidorn commented Sep 2, 2020

Great! Then we should just copy what Problems is doing

Assigning to September so I tackle then if no PR's arrive

@isidorn isidorn modified the milestones: Backlog, September 2020 Sep 2, 2020
@pfongkye
Copy link
Contributor

pfongkye commented Sep 5, 2020

Hi @isidorn
I can take a look into this if no one else is assigned.

@isidorn
Copy link
Contributor

isidorn commented Sep 7, 2020

@pfongkye sounds great. We should just have the exact same functionality as the Problems view, so checking how it is done there is a good start.

@isidorn
Copy link
Contributor

isidorn commented Sep 16, 2020

@pfongkye friendly ping regarding this, since if you are not looking into it I might take a look next week...

@pfongkye
Copy link
Contributor

@pfongkye friendly ping regarding this, since if you are not looking into it I might take a look next week...

Hi @isidorn sorry, I didn't have time last week. I've just started looking into the issue. I hope to have something ready for next week if it's ok with you. I'll keep you updated. Thanks.

@isidorn
Copy link
Contributor

isidorn commented Sep 16, 2020

@pfongkye great thanks. Since you are already on this I will remove the help wanted label

@isidorn isidorn removed GraceHopperOSD help wanted Issues identified as good community contribution opportunities labels Sep 16, 2020
isidorn added a commit that referenced this issue Sep 22, 2020
@isidorn isidorn added the verification-needed Verification of issue is requested label Sep 22, 2020
@isidorn
Copy link
Contributor

isidorn commented Sep 22, 2020

Thanks to @pfongkye we now have this.
Adding verification needed so we get this verified:

  • Start debugging and verify when using the debug filter that the filter shows what is the number of hidden items

@connor4312 connor4312 added the verified Verification succeeded label Sep 29, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants
@roblourens @pfongkye @isidorn @connor4312 @sana-ajani @sandy081 and others