Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger "Save As..." for virtual document editors when saving #101952

Closed
Gruntfuggly opened this issue Jul 8, 2020 · 4 comments
Closed

Trigger "Save As..." for virtual document editors when saving #101952

Gruntfuggly opened this issue Jul 8, 2020 · 4 comments
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes verification-needed Verification of issue is requested verified Verification succeeded workbench-editors Managing of editor widgets in workbench window

Comments

@Gruntfuggly
Copy link

Gruntfuggly commented Jul 8, 2020

I'm creating a document using TextDocumentContentProvider. This works well, however I would also like to be able to save the document.

  • the context menu has Save greyed out
  • the File menu allows me to click Save, but does nothing
  • the File menu Save As... does work

I think in all three cases it should simply do the Save As functionality.

@jrieken jrieken assigned bpasero and unassigned jrieken Jul 9, 2020
@bpasero bpasero changed the title Documents created with TextDocumentContentProvider have inconsistent Save behaviour Trigger "Save As..." for virtual document editors when saving Jul 9, 2020
@bpasero bpasero added feature-request Request for new features or functionality workbench-editors Managing of editor widgets in workbench window labels Jul 9, 2020
@bpasero bpasero removed their assignment Jul 9, 2020
@bpasero bpasero self-assigned this Sep 7, 2020
@bpasero bpasero closed this as completed in 183d11a Sep 7, 2020
@bpasero
Copy link
Member

bpasero commented Sep 7, 2020

I am pushing a change that should enable the flow of "File > Save" (or CtrlCmd+S) to bring up the save dialog even for virtual documents. I hope this does not break any existing flows, so may have to revisit this during the milestone.

1div0 pushed a commit to 1div0/vscode that referenced this issue Sep 7, 2020
@bpasero bpasero added the verification-needed Verification of issue is requested label Sep 25, 2020
@bpasero
Copy link
Member

bpasero commented Sep 25, 2020

Verification: open a readonly document from a virtual document provider (for example stepping into internal source when debugging or F1 > Startup Performance). Verify you can CtrlCmd+S to save the document and a meaningful name is presented. Once you save, verify the file is opened (similar to saving an untitled file).

@jrieken jrieken added the verified Verification succeeded label Sep 29, 2020
@bpasero bpasero added the on-release-notes Issue/pull request mentioned in release notes label Oct 1, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes verification-needed Verification of issue is requested verified Verification succeeded workbench-editors Managing of editor widgets in workbench window
Projects
None yet
Development

No branches or pull requests

4 participants
@Gruntfuggly @bpasero @jrieken and others