fixes #12985

microsoft · Sep 29, 2016 · adb9c23 · adb9c23
1 parent fe99e44
commit adb9c23
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/vs/platform/extensionManagement/node/extensionGalleryService.ts b/src/vs/platform/extensionManagement/node/extensionGalleryService.ts
@@ -542,7 +542,10 @@ export class ExtensionGalleryService implements IExtensionGalleryService {
 		return this._getAsset({ url, headers })
 			.then(context => asJson<IExtensionManifest>(context))
 			.then(manifest => {
-				if (!isVersionValid(pkg.version, manifest.engines.vscode)) {
+				const engine = manifest.engines.vscode;
+
+				// TODO@joao: discuss with alex '*' doesn't seem to be a valid engine version
+				if (engine !== '*' && !isVersionValid(pkg.version, engine)) {
 					return this.getLastValidExtensionVersionReccursively(extension, versions.slice(1));
 				}