Make sure we dispose of webviews in correct order

Fixes #85621 We must fire the the dispose event before disposing of the event
microsoft · Nov 26, 2019 · a8158ae · a8158ae
1 parent 776c33a
commit a8158ae
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/vs/workbench/api/browser/mainThreadWebview.ts b/src/vs/workbench/api/browser/mainThreadWebview.ts
@@ -334,16 +334,16 @@ export class MainThreadWebviews extends Disposable implements extHostProtocol.Ma
 
 		disposables.add(input.webview.onDidClickLink((uri: URI) => this.onDidClickLink(handle, uri)));
 		disposables.add(input.webview.onMessage((message: any) => { this._proxy.$onMessage(handle, message); }));
-		disposables.add(input.onDisposeWebview(() => {
-			this._proxy.$onDidDisposeWebviewPanel(handle).finally(() => {
-				this._webviewInputs.delete(handle);
-			});
-		}));
 		disposables.add(input.webview.onMissingCsp((extension: ExtensionIdentifier) => this._proxy.$onMissingCsp(handle, extension.value)));
 
 		input.onDispose(() => {
 			disposables.dispose();
 		});
+		input.onDisposeWebview(() => {
+			this._proxy.$onDidDisposeWebviewPanel(handle).finally(() => {
+				this._webviewInputs.delete(handle);
+			});
+		});
 	}
 
 	private updateWebviewViewStates() {

diff --git a/src/vs/workbench/contrib/webview/browser/webviewEditorInput.ts b/src/vs/workbench/contrib/webview/browser/webviewEditorInput.ts
@@ -90,11 +90,11 @@ export class WebviewInput extends EditorInput {
 	}
 
 	dispose() {
-		super.dispose();
 		if (!this._didSomeoneTakeMyWebview) {
 			this._webview?.rawValue?.dispose();
 			this._onDisposeWebview.fire();
 		}
+		super.dispose();
 	}
 
 	public getTypeId(): string {