Renaming tag for settings for online services #54354

microsoft · Jul 27, 2018 · 9e411a5 · 9e411a5
1 parent dbbfaf4
commit 9e411a5
Show file tree

Hide file tree

Showing 9 changed files with 14 additions and 14 deletions.
diff --git a/extensions/git/package.json b/extensions/git/package.json
@@ -912,7 +912,7 @@
           "type": "boolean",
           "description": "%config.autofetch%",
           "default": false,
-          "tags": ["backgroundOnlineFeature"]
+          "tags": ["usesOnlineServices"]
         },
         "git.confirmSync": {
           "type": "boolean",

diff --git a/extensions/typescript-language-features/package.json b/extensions/typescript-language-features/package.json
@@ -74,7 +74,7 @@
           "default": false,
           "description": "%typescript.disableAutomaticTypeAcquisition%",
           "scope": "window",
-          "tags": ["backgroundOnlineFeature"]
+          "tags": ["usesOnlineServices"]
         },
         "typescript.npm": {
           "type": [

diff --git a/src/vs/platform/telemetry/common/telemetryService.ts b/src/vs/platform/telemetry/common/telemetryService.ts
@@ -168,7 +168,7 @@ Registry.as<IConfigurationRegistry>(Extensions.Configuration).registerConfigurat
 			'type': 'boolean',
 			'description': localize('telemetry.enableTelemetry', "Enable usage data and errors to be sent to Microsoft."),
 			'default': true,
-			'tags': ['backgroundOnlineFeature']
+			'tags': ['usesOnlineServices']
 		}
 	}
 });
diff --git a/src/vs/platform/update/node/update.config.contribution.ts b/src/vs/platform/update/node/update.config.contribution.ts
@@ -22,20 +22,20 @@ configurationRegistry.registerConfiguration({
 			'default': 'default',
 			'scope': ConfigurationScope.APPLICATION,
 			'description': nls.localize('updateChannel', "Configure whether you receive automatic updates from an update channel. Requires a restart after change."),
-			'tags': ['backgroundOnlineFeature']
+			'tags': ['usesOnlineServices']
 		},
 		'update.enableWindowsBackgroundUpdates': {
 			'type': 'boolean',
 			'default': true,
 			'scope': ConfigurationScope.APPLICATION,
 			'description': nls.localize('enableWindowsBackgroundUpdates', "Enables Windows background updates."),
-			'tags': ['backgroundOnlineFeature']
+			'tags': ['usesOnlineServices']
 		},
 		'update.showReleaseNotes': {
 			'type': 'boolean',
 			'default': true,
 			'description': nls.localize('showReleaseNotes', "Show Release Notes after an update."),
-			'tags': ['backgroundOnlineFeature']
+			'tags': ['usesOnlineServices']
 		}
 	}
 });
diff --git a/src/vs/workbench/electron-browser/main.contribution.ts b/src/vs/workbench/electron-browser/main.contribution.ts
@@ -489,7 +489,7 @@ configurationRegistry.registerConfiguration({
 			'description': nls.localize('enableNaturalLanguageSettingsSearch', "Controls whether to enable the natural language search mode for settings."),
 			'default': true,
 			'scope': ConfigurationScope.WINDOW,
-			'tags': ['backgroundOnlineFeature']
+			'tags': ['usesOnlineServices']
 		},
 		'workbench.settings.settingsSearchTocBehavior': {
 			'type': 'string',

diff --git a/src/vs/workbench/parts/extensions/electron-browser/extensions.contribution.ts b/src/vs/workbench/parts/extensions/electron-browser/extensions.contribution.ts
@@ -207,7 +207,7 @@ Registry.as<IConfigurationRegistry>(ConfigurationExtensions.Configuration)
 				description: localize('extensionsAutoUpdate', "Automatically update extensions."),
 				default: true,
 				scope: ConfigurationScope.APPLICATION,
-				tags: ['backgroundOnlineFeature']
+				tags: ['usesOnlineServices']
 			},
 			'extensions.ignoreRecommendations': {
 				type: 'boolean',
@@ -218,7 +218,7 @@ Registry.as<IConfigurationRegistry>(ConfigurationExtensions.Configuration)
 				type: 'boolean',
 				description: localize('extensionsShowRecommendationsOnlyOnDemand', "When enabled, recommendations will not be fetched or shown unless specifically requested by the user."),
 				default: false,
-				tags: ['backgroundOnlineFeature']
+				tags: ['usesOnlineServices']
 			},
 			'extensions.closeExtensionDetailsOnViewChange': {
 				type: 'boolean',

diff --git a/src/vs/workbench/parts/preferences/browser/settingsEditor2.ts b/src/vs/workbench/parts/preferences/browser/settingsEditor2.ts
@@ -32,7 +32,7 @@ import { BaseEditor } from 'vs/workbench/browser/parts/editor/baseEditor';
 import { EditorOptions, IEditor } from 'vs/workbench/common/editor';
 import { SearchWidget, SettingsTarget, SettingsTargetsWidget } from 'vs/workbench/parts/preferences/browser/preferencesWidgets';
 import { commonlyUsedData, tocData } from 'vs/workbench/parts/preferences/browser/settingsLayout';
-import { ISettingsEditorViewState, resolveExtensionsSettings, resolveSettingsTree, SearchResultIdx, SearchResultModel, SettingsRenderer, SettingsTree, SettingsTreeElement, SettingsTreeFilter, SettingsTreeGroupElement, SettingsTreeModel, SettingsTreeSettingElement, MODIFIED_SETTING_TAG, BACKGROUND_ONLINE_TAG } from 'vs/workbench/parts/preferences/browser/settingsTree';
+import { ISettingsEditorViewState, resolveExtensionsSettings, resolveSettingsTree, SearchResultIdx, SearchResultModel, SettingsRenderer, SettingsTree, SettingsTreeElement, SettingsTreeFilter, SettingsTreeGroupElement, SettingsTreeModel, SettingsTreeSettingElement, MODIFIED_SETTING_TAG, ONLINE_SERVICES_SETTING_TAG } from 'vs/workbench/parts/preferences/browser/settingsTree';
 import { TOCDataSource, TOCRenderer, TOCTreeModel } from 'vs/workbench/parts/preferences/browser/tocTree';
 import { CONTEXT_SETTINGS_EDITOR, CONTEXT_SETTINGS_FIRST_ROW_FOCUS, CONTEXT_SETTINGS_ROW_FOCUS, CONTEXT_SETTINGS_SEARCH_FOCUS, CONTEXT_TOC_ROW_FOCUS, IPreferencesSearchService, ISearchProvider } from 'vs/workbench/parts/preferences/common/preferences';
 import { IPreferencesService, ISearchResult, ISettingsEditorModel } from 'vs/workbench/services/preferences/common/preferences';
@@ -236,8 +236,8 @@ export class SettingsEditor2 extends BaseEditor {
 				this),
 			this.instantiationService.createInstance(
 				FilterByTagAction,
-				localize('filterBackgroundOnlineLabel', "Control background online features"),
-				BACKGROUND_ONLINE_TAG,
+				localize('filterOnlineServicesLabel', "Show settings for online services"),
+				ONLINE_SERVICES_SETTING_TAG,
 				this),
 			new Separator(),
 			this.instantiationService.createInstance(OpenSettingsAction)

diff --git a/src/vs/workbench/parts/preferences/browser/settingsTree.ts b/src/vs/workbench/parts/preferences/browser/settingsTree.ts
@@ -41,7 +41,7 @@ import { ISearchResult, ISetting, ISettingsGroup } from 'vs/workbench/services/p
 const $ = DOM.$;
 
 export const MODIFIED_SETTING_TAG = 'modified';
-export const BACKGROUND_ONLINE_TAG = 'backgroundOnlineFeature';
+export const ONLINE_SERVICES_SETTING_TAG = 'usesOnlineServices';
 
 export abstract class SettingsTreeElement {
 	id: string;

diff --git a/src/vs/workbench/services/crashReporter/electron-browser/crashReporterService.ts b/src/vs/workbench/services/crashReporter/electron-browser/crashReporterService.ts
@@ -38,7 +38,7 @@ configurationRegistry.registerConfiguration({
 			'type': 'boolean',
 			'description': nls.localize('telemetry.enableCrashReporting', "Enable crash reports to be sent to Microsoft.\nThis option requires restart to take effect."),
 			'default': true,
-			'tags': ['backgroundOnlineFeature']
+			'tags': ['usesOnlineServices']
 		}
 	}
 });