Skip to content

Commit

Permalink
finish fix #64596
Browse files Browse the repository at this point in the history
  • Loading branch information
bpasero committed Dec 11, 2018
1 parent e52ffb2 commit 742bae2
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions src/vs/platform/windows/node/windowsIpc.ts
Original file line number Diff line number Diff line change
Expand Up @@ -213,8 +213,8 @@ export class WindowsChannelClient implements IWindowsService {
}

getRecentlyOpened(windowId: number): TPromise<IRecentlyOpened> {
return TPromise.wrap<IRecentlyOpened>(this.channel.call('getRecentlyOpened', windowId))
.then(recentlyOpened => {
return this.channel.call('getRecentlyOpened', windowId)
.then((recentlyOpened: IRecentlyOpened) => {
recentlyOpened.workspaces = recentlyOpened.workspaces.map(workspace => isWorkspaceIdentifier(workspace) ? workspace : URI.revive(workspace));
recentlyOpened.files = recentlyOpened.files.map(URI.revive);
return recentlyOpened;
Expand Down
2 changes: 1 addition & 1 deletion src/vs/workbench/services/editor/browser/editorService.ts
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ export class EditorService extends Disposable implements EditorServiceImpl {
return this.doOpenEditor(targetGroup, typedInput, editorOptions);
}

return TPromise.wrap<IEditor>(null);
return Promise.resolve(null);
}

protected doOpenEditor(group: IEditorGroup, editor: IEditorInput, options?: IEditorOptions): TPromise<IEditor> {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ export class TextFileEditorModel extends BaseTextEditorModel implements ITextFil

revert(soft?: boolean): TPromise<void> {
if (!this.isResolved()) {
return TPromise.wrap<void>(null);
return Promise.resolve(null);
}

// Cancel any running auto-save
Expand Down Expand Up @@ -584,7 +584,7 @@ export class TextFileEditorModel extends BaseTextEditorModel implements ITextFil

save(options: ISaveOptions = Object.create(null)): TPromise<void> {
if (!this.isResolved()) {
return TPromise.wrap<void>(null);
return Promise.resolve(null);
}

this.logService.trace('save() - enter', this.resource);
Expand Down Expand Up @@ -623,7 +623,7 @@ export class TextFileEditorModel extends BaseTextEditorModel implements ITextFil
if ((!options.force && !this.dirty) || versionId !== this.versionId) {
this.logService.trace(`doSave(${versionId}) - exit - because not dirty and/or versionId is different (this.isDirty: ${this.dirty}, this.versionId: ${this.versionId})`, this.resource);

return TPromise.wrap<void>(null);
return Promise.resolve(null);
}

// Return if currently saving by storing this save request as the next save that should happen.
Expand Down

0 comments on commit 742bae2

Please sign in to comment.