Fix what an empty string is, don't render empty MarkdownString, #29076

microsoft · Aug 24, 2017 · 57da808 · 57da808
1 parent fb83608
commit 57da808
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/vs/base/common/htmlContent.ts b/src/vs/base/common/htmlContent.ts
@@ -17,7 +17,7 @@ export class MarkdownString implements IMarkdownString {
 
 	static isEmpty(oneOrMany: IMarkdownString | IMarkdownString[]): boolean {
 		if (MarkdownString.isMarkdownString(oneOrMany)) {
-			return Boolean(oneOrMany.value);
+			return !oneOrMany.value;
 		} else if (Array.isArray(oneOrMany)) {
 			return oneOrMany.every(MarkdownString.isEmpty);
 		} else {
@@ -49,11 +49,11 @@ export class MarkdownString implements IMarkdownString {
 	}
 
 	appendCodeblock(langId: string, code: string): this {
-		this.value += '```';
+		this.value += '\n```';
 		this.value += langId;
 		this.value += '\n';
 		this.value += code;
-		this.value += '```\n';
+		this.value += '\n```\n';
 		return this;
 	}
 }

diff --git a/src/vs/editor/contrib/hover/browser/modesContentHover.ts b/src/vs/editor/contrib/hover/browser/modesContentHover.ts
@@ -310,7 +310,7 @@ export class ModesContentHoverWidget extends ContentHoverWidget {
 
 			if (!(msg instanceof ColorHover)) {
 				msg.contents
-					.filter(contents => !!contents)
+					.filter(contents => !MarkdownString.isEmpty(contents))
 					.forEach(contents => {
 						const renderedContents = renderMarkdown(contents, {
 							actionCallback: (content) => {