Fix shrinking checkbox when parent container shrinks #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkticehurst
requested changes
Mar 7, 2024
hawkticehurst
approved these changes
Mar 8, 2024
hawkticehurst
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to relevant issue
This pull request resolves #539
Description of changes
The width and height inherited from the parent container will override the
width: 16andheight: 16in the<svg>. If the parent container makes the checkbox shrink below 16px, the size will be skewed. Addingmid-widthandmin-heightwill prevent this to happen.webview-ui-toolkit-checkbox-fix.mp4