Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt JSON Storybook Control #28

Closed
hawkticehurst opened this issue Mar 16, 2021 · 0 comments · Fixed by #57
Closed

Adopt JSON Storybook Control #28

hawkticehurst opened this issue Mar 16, 2021 · 0 comments · Fixed by #57
Assignees
@hawkticehurst

Comments

@hawkticehurst
Copy link
Member

Currently, the VSCode Data Grid component gridData Storybook control renders the input JSON as a plain text box, which is hard to edit and view as a user.

Storybook has already merged a PR that adds a JSON editor/tree view control to the control options but it is currently published as a prerelease feature.

When the feature is added in a stable release update the gridData control to use this new feature.

Storybook Issue: storybookjs/storybook#12599
Storybook PR: storybookjs/storybook#12824
@hawkticehurst hawkticehurst changed the title infrastructure/adopt-json-storybook-control Adopt JSON Storybook Control Mar 17, 2021
@hawkticehurst hawkticehurst self-assigned this Mar 19, 2021
@hawkticehurst hawkticehurst mentioned this issue Apr 7, 2021
Merged
hawkticehurst added a commit that referenced this issue Apr 7, 2021
@hawkticehurst
Update VSCode Data Grid Documentation & Stories (#57)
67436a6 
Conduct the first polishing pass of the VSCode Data Grid component. Changes include:

- Updating and adding to the VSCode Data Grid README documentation
- Adding more Storybook controls and stories

Also, adopted the JSON Storybook tree view control. Resolves #28.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hawkticehurst hawkticehurst

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update VSCode Data Grid Documentation & Stories microsoft/vscode-webview-ui-toolkit
1 participant
@hawkticehurst