-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding container definition fails #7648
Comments
Could you append the container log when this fails? ( |
So that's where the logs are 🎉
|
I have the same issue. It's happening in WSL2 and on Windows. I updated from extension version 0.262.3 to 0.266.1. Devcontainer log just prints: [424477 ms] -- CREATEDEVCONTAINER v2
[429398 ms] Start: Run: C:\Users\<user>\AppData\Local\Programs\Microsoft VS Code\Code.exe --ms-enable-electron-run-as-node c:\Users\<user>\.vscode\extensions\ms-vscode-remote.remote-containers-0.266.1\dist\spec-node\devContainersSpecCLI.js templates apply --workspace-folder D:\Temp\tmp-output-dir-1670533304110 --template-id ghcr.io/devcontainers/templates/docker-existing-docker-compose:latest --template-args {} --features [] --tmp-dir D:\Temp\tmp-dir-1670533304110
[429732 ms] [2022-12-08T21:01:44.444Z] @devcontainers/cli 0.25.2. Node.js v16.14.2. win32 10.0.19045 x64.
[429763 ms] (node:30104) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
[429764 ms] (Use `Code --trace-deprecation ...` to show where the warning was created) Also devcontainers should see the new recommended "compose.ya?ml" file [ref] and create configs from it. |
Seems like it now fails if there is an issue with the network connection. In my case i think it's related to self signed certificates:
|
Also experiencing this, and also seems related to self signed certificates.
|
@joshspicer @samruddhikhandale Something with the registry access seems off. Could you take a look? Also: Not all logs show the same error. Some are 403s while others are about self signed certificates. |
I haven't been able to reproduce any of these instances yet. I have noticed that each instance of this was on 0.25.2, before significant changes to the OCI code was changed in 0.26.0. This seems like it would be a limitation of our https library follow-redirects, although I am not yet sure how. |
I have the same certificate error using macOS 12.6.1 on an M1 with VS Code 1.74.2 and Dev Containers 0.266.1 Update: This issue was resolved by setting the Netskope certificate in Keychain to 'Always Trust' |
What led you to make this change @markba ? |
The error indicated self-signed certificates being part of the problem, so I started with something I know that MITM's my connection @joshspicer |
I will add that I am experiencing the same. We are also using a self signed certificate: |
I also had this problem (403 errors) with Dev Containers 0.266.1 in VS Code 1.74.2 so I went back 2 releases with the extension, created the container and then updated the extension to latest and it's working but it wasn't an obvious workaround. |
@wadebee does the solution mentioned in #7648 (comment) work for you? |
I am not able to reproduce the 403 errors.
I don't think we released |
@samruddhikhandale I just checked the extension version again and it's correct and I can still reliably reproduce the problem. Here's the log from doing it again:
|
I think this is duplicate of #7431 |
@eitsupi I agree, this happens to me both locally and over SSH |
Dev Containers 0.270.0-pre-release comes with the auth improvements in devcontainers/cli#341 in case this makes a difference. Not sure if the 403 is related to proxy support in #7431. |
For context - I'm having the Error: self signed certificate in certificate chain issue. @chrmarti I upgraded to the 0.270.0-pre-release version of Dev Containers, and I'm still having the same issue. I'm providing references to features in the OCI registry as suggested by #7150 but I'm still getting the error. Below is a snippet from the feature definition of my devcontainer.json. I get the error when I uncomment this block:
The error log features the following
I have a near identical configuration to markba as described in his comment but unfortunately adding the certs as trusted didn't fix my issue. I've hit a wall and tried all the suggestions I've found and then some. Really looking forward to someone getting to the bottom of this so I can start using it in my development and hopefully contributing. |
if you remove all the features from devcontainer's "features" set, then, it is able to launch the dev container successfully. This looks like issue which fetching images/packages for new features. I used vscode-remote-try-rust to launch devcontainer and once it was successfully created and run, I added random feature to devcontainer and when I tried to rebuild the container it failed with timeout to fetch the newly added feature. |
By the way, I tried to launch devcontainer with feature using fedora wsl and it worked seamlessly, the same is still failing for ubuntu and ubuntu 22.04.
Various things updated in between, but, ubuntu still are not working. I think something specific is broken with wsl setting for ubuntu images. |
I'm having this issue, too. Windows 10. Initially, I thought it was because I was doing it through SSH remoting, but I can reproduce this even if I'm just doing the create configuration option on a local empty folder. It complains about not being able to open the It seems to be specific images, though. The This issue seems to have been around awhile, so it'd be nice if it got some attention. |
Steps to Reproduce:
Error message:
Does this issue occur when you try this locally?: N/A
Does this issue occur when you try this locally and all extensions are disabled?: N/A
The text was updated successfully, but these errors were encountered: