Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work with Rancher Desktop #6252

Closed
5H3PH3RDCSG opened this issue Jan 28, 2022 · 5 comments
Closed

Does not work with Rancher Desktop #6252

5H3PH3RDCSG opened this issue Jan 28, 2022 · 5 comments
Labels
containers Issue in vscode-remote containers feature-request Request for new features or functionality
Milestone

Comments

@5H3PH3RDCSG
Copy link

Issue Type: Feature Request

Allow the use of Rancher Desktop instead of Docker Desktop.

Extension version: 0.209.6
VS Code version: Code 1.63.2 (899d46d82c4c95423fb7e10e68eba52050e30ba3, 2021-12-15T09:40:02.816Z)
OS version: Windows_NT x64 10.0.19042
Restricted Mode: No

@tanhakabir tanhakabir added containers Issue in vscode-remote containers feature-request Request for new features or functionality labels Jan 30, 2022
@gpyga
Copy link

gpyga commented Mar 2, 2022

@5H3PH3RDCSG, this guide is new as of raising this issue. Looks like it was committed Feb 14th, 2022. The gist is that you have to be using the dockerd runtime.

@Chuxel
Copy link
Member

Chuxel commented Mar 23, 2022

The link changed, but @gpyga 's point is right. https://docs.rancherdesktop.io/how-to-guides/vs-code-remote-containers

Also, nerdctl support is tracked as #6014. devcontainers/spec#11 and devcontainers/spec#9 are also relevant for community contributions here. With that in mind, I'd propose we close this as resolved.

@Chuxel Chuxel closed this as completed Mar 23, 2022
@anton-kirschhock
Copy link

I've just tried using nerdctl instead the dockercli in remote containers and it fails during checking the version of the docker api:
level=fatal msg="template: :1:9: executing "" at <.Server.APIVersion>: can't evaluate field APIVersion in type *dockercompat.ServerVersion"
After some trail & error, I could fetch the server version with the following command:
nerdctl version --format '{{(index .Server.Components 0).Version}}'

After this, I've done some digging in moby's source code compared to the nerdctl sourcecode and I've noticed that the Properties .Server.Version are marked deprecated and are kept for backwards compat.:
https://github.com/moby/moby/blob/2ed904cad7055847796433cc56ef1d1de0da868c/api/types/types.go#L219
The nerdctl guys did not implement it in their implementation: https://github.com/containerd/nerdctl/blob/2b4e3bde28d67d08c85bcf15fef23d973bae590f/pkg/inspecttypes/dockercompat/info.go#L95.

I wonder, whether you guys could add extra configuration entries like Version format template (so we can configure the version template thingy) and also making the minimum version configurable, I could try using Devcontainers + nerdctl.

Or, alternatively give users the options to disable versionchecks all together and just hint out to users that the devcontainers might not work 100% or something.
Just throwing out some ideas...

@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
containers Issue in vscode-remote containers feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

6 participants
@Chuxel @anton-kirschhock @gpyga @tanhakabir @5H3PH3RDCSG and others