-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish reference implementation #9
Comments
Thanks for opening this!
I like this as it feels like it allows for easier iteration on the dev container. |
👍 This would be great to do. This would also allow us to prebuild devcontainer definitions using the CLI to generate a docker image that can be used as the |
As we've been looking at the reference implementation, there's a couple of important gaps here at the moment. Initally I was thinking the So to really say we have a reference implementation, I think we'd need:
...which would allow you to execute a command in the terminal that would take into account We'd also then need:
... or down which would bring down the containers since the Ids are not fixed. We can open up what is already coming together and just be clear about these gaps while we continue to work on them. |
There might be two stories to tell here: One is about the reference implementation that can be used to build products like Codespaces and Remote-Containers and one is about a CLI that can be used in CI. We could add a |
Yeah we could add |
Adding an |
The reference implementation is now available at https://github.com/devcontainers/cli! Closing this issue as the CLI repo is published, but please let me know if there's more we should discuss here. Thanks! |
We want to extract a reference implementation for the dev container spec from our existing implementation. The current proposal is to make a CLI available that can take a devcontainer.json and create and configure a dev container from it.
Splitting it into 2 stages at first:
up
could be split intobuild
andrun
to make building the image available separately.run-user-commands
runs"postCreateCommand"
and other user-provided commands.Products might choose to add to the container's setup between the two commands (e.g., Remote-Containers starts the ssh-agent forwarding among other things).
/cc @joshspicer @Chuxel @2percentsilk @bamurtaugh
The text was updated successfully, but these errors were encountered: